Skip to content

update runc binary and libcontainer to v1.0.1#42654

Merged
justincormack merged 5 commits intomoby:masterfrom
AkihiroSuda:runc-v1.0.1
Jul 19, 2021
Merged

update runc binary and libcontainer to v1.0.1#42654
justincormack merged 5 commits intomoby:masterfrom
AkihiroSuda:runc-v1.0.1

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda commented Jul 18, 2021

Release note: https://github.com/opencontainers/runc/releases/tag/v1.0.1

Also updates libcontainer and its dependencies https://github.com/opencontainers/runc/compare/v1.0.0-rc95...v1.0.1#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyphar
Copy link
Copy Markdown
Contributor

cyphar commented Jul 19, 2021

Since this update contains fixes to libcontainer/user (which Docker uses for docker run --user ... handling), shouldn't we also update vendor.conf?

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda changed the title update runc binary to v1.0.1 update runc binary and libcontainer to v1.0.1 Jul 19, 2021
@AkihiroSuda
Copy link
Copy Markdown
Member Author

Updated PR to vendor libcontainer as well.

Not sure we can cherry-pick to v20.10 though.

https://github.com/moby/moby/blob/v20.10.7/vendor.conf#L93

@thaJeztah
Copy link
Copy Markdown
Member

Not sure either. IIUC, it's not a regression, so would've been an issue already for a long time (but perhaps I'm wrong and it was introduced recently?).

My concern is that moby still uses quite a lot from libcontainer, so updating would bring many other changes (potentially with many dependencies that also need updating), so unless the issue that's fixed is critical, I'd rather not include it, and instead focus on "what's left before we do a 21.xx release"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants