Remove LCOW (step 5): volumes/mounts: remove LCOW code#42517
Closed
thaJeztah wants to merge 1 commit intomoby:masterfrom
Closed
Remove LCOW (step 5): volumes/mounts: remove LCOW code#42517thaJeztah wants to merge 1 commit intomoby:masterfrom
thaJeztah wants to merge 1 commit intomoby:masterfrom
Conversation
Member
Author
|
looks like there a test / file missing a build tag to skip it on windows edit: fixed |
Both "windows" and "linux" parsers were previously compiled on all platforms, so that both semantics could be handled; now that LCOW is removed, renaming these files back to be compiled only on the matching platform. With the OS-specific handling being removed, the "OS" parameter is also removed from `daemon.verifyContainerSettings()`. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
11ba763 to
d99fa02
Compare
AkihiroSuda
approved these changes
Jun 12, 2021
Member
Author
|
I'm gonna try a slightly different alternative as well, where I keep the code to do the cross-platform mount (validation), but by default do "native" (so that we don't have to punch through the "os" in all code. |
Member
Author
|
Closing this one in favour of #42520 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
splitting from #42170
Both "windows" and "linux" parsers were previously compiled on all platforms, so that both semantics could be handled; now that LCOW is removed, renaming these files back to be compiled only on the matching platform.
With the OS-specific handling being removed, the "OS" parameter is also removed from
daemon.verifyContainerSettings().- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)