Skip to content

Dockerfile: install criu from binary repo (carry 41739)#42453

Merged
tianon merged 1 commit intomoby:masterfrom
thaJeztah:carry_41739_bin_criu
Jun 2, 2021
Merged

Dockerfile: install criu from binary repo (carry 41739)#42453
tianon merged 1 commit intomoby:masterfrom
thaJeztah:carry_41739_bin_criu

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Jun 1, 2021

carry of #41739 with changes from #41739 (comment) applied

closes #41739
closes #42362

@thaJeztah thaJeztah added status/2-code-review area/testing kind/refactor PR's that refactor, or clean-up code labels Jun 1, 2021
@thaJeztah thaJeztah added this to the 21.xx milestone Jun 1, 2021
@thaJeztah thaJeztah force-pushed the carry_41739_bin_criu branch from f3bcea0 to 7a43d48 Compare June 1, 2021 12:22
@thaJeztah thaJeztah mentioned this pull request Jun 1, 2021
Closed
@thaJeztah thaJeztah force-pushed the carry_41739_bin_criu branch from 7a43d48 to 93c9d6a Compare June 1, 2021 12:24
@kolyshkin @thaJeztah
Dockerfile: install criu from binary repo
c8e6ad1 
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the carry_41739_bin_criu branch from 93c9d6a to c8e6ad1 Compare June 1, 2021 12:38
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Jun 1, 2021

@tianon @kolyshkin ptal

@thaJeztah thaJeztah mentioned this pull request Jun 1, 2021
Merged
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Jun 1, 2021

Failing on TestRunPIDsLimit (known flaky: #42416)

Looks like it has become more flaky recently (I think around the time we updated runc, so possibly related?)

Details 
=== RUN   TestDockerSuite/TestRunPIDsLimit
    --- FAIL: TestDockerSuite/TestRunPIDsLimit (0.92s)
        docker_cli_run_unix_test.go:1395: assertion failed: 
            Command:  /usr/local/cli/docker run --name skittles --pids-limit 4 busybox cat /sys/fs/cgroup/pids/pids.max
            ExitCode: 125
            Error:    exit status 125
            Stdout:   
            Stderr:   runtime/cgo: pthread_create failed: Resource temporarily unavailable
            SIGABRT: abort
            PC=0x91ce6b m=2 sigcode=18446744073709551610
            
            goroutine 0 [idle]:
            runtime: unknown pc 0x91ce6b
            stack: frame={sp:0x7f05a83976c0, fp:0x0} stack=[0x7f05a7b98148,0x7f05a8397d48)
            00007f05a83975c0:  0000000000000000  0000000000000000 
            00007f05a83975d0:  0000000000000000  0000000000000000 
            00007f05a83975e0:  0000000000000000  0000000000000000 
            00007f05a83975f0:  0000000000000000  0000000000000000 
            00007f05a8397600:  0000000000000000  0000000000000000 
            00007f05a8397610:  0000000000000000  0000000000000000 
            00007f05a8397620:  0000000000000000  0000000000000000 
            00007f05a8397630:  0000000000000000  0000000000000000 
            00007f05a8397640:  0000000000000000  0000000000000000 
            00007f05a8397650:  0000000000000000  0000000000000000 
            00007f05a8397660:  0000000000000000  000000000042cf30 <runtime.netpoll+320> 
            00007f05a8397670:  0000000000000007  00007f05a83976a8 
            00007f05a8397680:  0000000000000080  0000000000000000 
            00007f05a8397690:  0000000000000000  0000000000000000 
            00007f05a83976a0:  00007f05a83976d0  000000000041f12c <runtime.(*mTreap).end+76> 
            00007f05a83976b0:  0000000000000000  0000000000000001 
            00007f05a83976c0: <0000000000000000  0000000100000000 
            00007f05a83976d0:  00007f05a8397760  0000000000428a5d <runtime.(*mheap).scavengeLocked+557> 
            00007f05a83976e0:  0000000000ff98e8  0000000000000003 
            00007f05a83976f0:  0000000000000001  000000000041ae14 <runtime.(*fixalloc).alloc+116> 
            00007f05a8397700:  00007f05aa5d7008  0000000000000038 
            00007f05a8397710:  0000000000000000  0000000000000000 
            00007f05a8397720:  0000000000000000  00007f05aa5d7008 
            00007f05a8397730:  00007f05a8397788  000000000041f40d <runtime.(*mTreap).insert+253> 
            00007f05a8397740:  fffffffe7fffffff  ffffffffffffffff 
            00007f05a8397750:  ffffffffffffffff  ffffffffffffffff 
            00007f05a8397760:  ffffffffffffffff  ffffffffffffffff 
            00007f05a8397770:  ffffffffffffffff  ffffffffffffffff 
            00007f05a8397780:  ffffffffffffffff  ffffffffffffffff 
            00007f05a8397790:  ffffffffffffffff  ffffffffffffffff 
            00007f05a83977a0:  ffffffffffffffff  ffffffffffffffff 
            00007f05a83977b0:  ffffffffffffffff  ffffffffffffffff 
            runtime: unknown pc 0x91ce6b
            stack: frame={sp:0x7f05a83976c0, fp:0x0} stack=[0x7f05a7b98148,0x7f05a8397d48)
            00007f05a83975c0:  0000000000000000  0000000000000000 
            00007f05a83975d0:  0000000000000000  0000000000000000 
            00007f05a83975e0:  0000000000000000  0000000000000000 
            00007f05a83975f0:  0000000000000000  0000000000000000 
            00007f05a8397600:  0000000000000000  0000000000000000 
            00007f05a8397610:  0000000000000000  0000000000000000 
            00007f05a8397620:  0000000000000000  0000000000000000 
            00007f05a8397630:  0000000000000000  0000000000000000 
            00007f05a8397640:  0000000000000000  0000000000000000 
            00007f05a8397650:  0000000000000000  0000000000000000 
            00007f05a8397660:  0000000000000000  000000000042cf30 <runtime.netpoll+320> 
            00007f05a8397670:  0000000000000007  00007f05a83976a8 
            00007f05a8397680:  0000000000000080  0000000000000000 
            00007f05a8397690:  0000000000000000  0000000000000000 
            00007f05a83976a0:  00007f05a83976d0  000000000041f12c <runtime.(*mTreap).end+76> 
            00007f05a83976b0:  0000000000000000  0000000000000001 
            00007f05a83976c0: <0000000000000000  0000000100000000 
            00007f05a83976d0:  00007f05a8397760  0000000000428a5d <runtime.(*mheap).scavengeLocked+557> 
            00007f05a83976e0:  0000000000ff98e8  0000000000000003 
            00007f05a83976f0:  0000000000000001  000000000041ae14 <runtime.(*fixalloc).alloc+116> 
            00007f05a8397700:  00007f05aa5d7008  0000000000000038 
            00007f05a8397710:  0000000000000000  0000000000000000 
            00007f05a8397720:  0000000000000000  00007f05aa5d7008 
            00007f05a8397730:  00007f05a8397788  000000000041f40d <runtime.(*mTreap).insert+253> 
            00007f05a8397740:  fffffffe7fffffff  ffffffffffffffff 
            00007f05a8397750:  ffffffffffffffff  ffffffffffffffff 
            00007f05a8397760:  ffffffffffffffff  ffffffffffffffff 
            00007f05a8397770:  ffffffffffffffff  ffffffffffffffff 
            00007f05a8397780:  ffffffffffffffff  ffffffffffffffff 
            00007f05a8397790:  ffffffffffffffff  ffffffffffffffff 
            00007f05a83977a0:  ffffffffffffffff  ffffffffffffffff 
            00007f05a83977b0:  ffffffffffffffff  ffffffffffffffff 
            
            goroutine 1 [runnable, locked to thread]:
            syscall.Syscall6(0x101, 0xffffffffffffff9c, 0xc000222ce0, 0x80001, 0x0, 0x0, 0x0, 0x3, 0x80001, 0x0)
            	syscall/asm_linux_amd64.s:44 +0x5
            github.com/opencontainers/runc/vendor/golang.org/x/sys/unix.openat(0xffffffffffffff9c, 0xc00019d0d8, 0xf, 0x80001, 0x0, 0xc00019d0d8, 0xf, 0xa01f40)
            	github.com/opencontainers/runc/vendor/golang.org/x/sys/unix/zsyscall_linux.go:77 +0xbb
            github.com/opencontainers/runc/vendor/golang.org/x/sys/unix.Open(...)
            	github.com/opencontainers/runc/vendor/golang.org/x/sys/unix/syscall_linux.go:90
            github.com/opencontainers/runc/libcontainer.(*linuxStandardInit).Init(0xc000154f90, 0x0, 0x0)
            	github.com/opencontainers/runc/libcontainer/standard_init_linux.go:197 +0x7b6
            github.com/opencontainers/runc/libcontainer.(*LinuxFactory).StartInitialization(0xc0000e8120, 0x0, 0x0)
            	github.com/opencontainers/runc/libcontainer/factory_linux.go:402 +0x4e7
            main.glob..func6(0xc0000a8840, 0x0, 0xc000130350)
            	github.com/opencontainers/runc/init.go:49 +0x4b
            github.com/opencontainers/runc/vendor/github.com/urfave/cli.HandleAction(0xa11500, 0xb09d50, 0xc0000a8840, 0xc0000a8840, 0x0)
            	github.com/opencontainers/runc/vendor/github.com/urfave/cli/app.go:523 +0xbe
            github.com/opencontainers/runc/vendor/github.com/urfave/cli.Command.Run(0xae295f, 0x4, 0x0, 0x0, 0x0, 0x0, 0x0, 0xb03408, 0x51, 0x0, ...)
            	github.com/opencontainers/runc/vendor/github.com/urfave/cli/command.go:174 +0x51c
            github.com/opencontainers/runc/vendor/github.com/urfave/cli.(*App).Run(0xc0000bc540, 0xc00000e0a0, 0x2, 0x2, 0x0, 0x0)
            	github.com/opencontainers/runc/vendor/github.com/urfave/cli/app.go:276 +0x718
            main.main()
            	github.com/opencontainers/runc/main.go:165 +0xbb1
            
            goroutine 7 [syscall]:
            os/signal.signal_recv(0x0)
            	runtime/sigqueue.go:147 +0x9c
            os/signal.loop()
            	os/signal/signal_unix.go:23 +0x22
            created by os/signal.init.0
            	os/signal/signal_unix.go:29 +0x41
            
            rax    0x0
            rbx    0x6
            rcx    0x91ce6b
            rdx    0x0
            rdi    0x2
            rsi    0x7f05a83976c0
            rbp    0xbd837a
            rsp    0x7f05a83976c0
            r8     0x0
            r9     0x7f05a83976c0
            r10    0x8
            r11    0x246
            r12    0x16b4d20
            r13    0x0
            r14    0xb95f1c
            r15    0x0
            rip    0x91ce6b
            rflags 0x246
            cs     0x33
            fs     0x0
            gs     0x0
            /usr/local/cli/docker: Error response from daemon: OCI runtime start failed: cannot start an already running container: unknown.
            time="2021-06-01T13:20:00Z" level=error msg="error waiting for container: context canceled" 
            
            
            Failures:
            ExitCode was 125 expected 0
            Expected no error

kolyshkin
kolyshkin approved these changes Jun 1, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and thanks for carrying

tianon
tianon approved these changes Jun 2, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTK(ir), LGTM

@tianon tianon merged commit 026eab0 into moby:master Jun 2, 2021
@thaJeztah thaJeztah deleted the carry_41739_bin_criu branch June 2, 2021 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianon tianon tianon approved these changes

@kolyshkin kolyshkin kolyshkin approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

area/testing kind/refactor PR's that refactor, or clean-up code status/2-code-review

Projects

None yet

Milestone

23.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah @tianon @kolyshkin @AkihiroSuda