[DNM] trigger CI with containerd v1.5.0-rc.3 + runc rc94-pre#42308
Closed
AkihiroSuda wants to merge 3 commits intomoby:masterfrom
Closed
[DNM] trigger CI with containerd v1.5.0-rc.3 + runc rc94-pre#42308AkihiroSuda wants to merge 3 commits intomoby:masterfrom
AkihiroSuda wants to merge 3 commits intomoby:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
c404a55 to
a15c979
Compare
thaJeztah
approved these changes
May 6, 2021
container/container_unix.go
Outdated
Member
There was a problem hiding this comment.
Can you move this commit to a separate PR?
This should also probably take the same approach as is used for secrets;
moby/container/container_unix.go
Line 234 in 7b9275c
And use a function like getSecretTargetPath();
Lines 711 to 717 in 7b9275c
Difference would be that containerSecretMountPath would be / on Linux, and C:/ on Windows (?))
moby/container/container_windows.go
Line 15 in 7b9275c
moby/container/container_unix.go
Line 30 in 7b9275c
Starting with runc v1.0.0-rc94, runc no longer supports KernelMemory. opencontainers/runc@52390d6 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Needed for runc >= 1.0.0-rc94. See runc issue 2928. Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Member
Author
|
Carried as #42369 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Triggering CI with containerd v1.5.0-rc.2 for ensuring that containerd 1.5 is compatible with the current Moby.