move golangci-lint to github actions#42303
Closed
thaJeztah wants to merge 4 commits intomoby:masterfrom
Closed
Conversation
78dd19c to
b0da8b5
Compare
This was referenced May 31, 2021
pkg/pidfile/pidfile.go:43:12: G306: Expect WriteFile permissions to be 0600 or less (gosec)
if err := ioutil.WriteFile(path, []byte(fmt.Sprintf("%d", os.Getpid())), 0644); err != nil {
^
pkg/plugins/pluginrpc-gen/main.go:82:33: G306: Expect WriteFile permissions to be 0600 or less (gosec)
errorOut("error writing file", ioutil.WriteFile(*outputFile, src, 0644))
^
testutil/fakecontext/context.go:99:9: G306: Expect WriteFile permissions to be 0600 or less (gosec)
return ioutil.WriteFile(fp, content, 0644)
^
daemon/graphdriver/graphtest/graphtest_unix.go:310:9: G306: Expect WriteFile permissions to be 0600 or less (gosec)
return ioutil.WriteFile(path, data, 0700)
^
layer/filestore.go:243:9: G306: Expect WriteFile permissions to be 0600 or less (gosec)
return ioutil.WriteFile(fms.getMountFilename(mount, "mount-id"), []byte(mountID), 0644)
^
layer/filestore.go:250:9: G306: Expect WriteFile permissions to be 0600 or less (gosec)
return ioutil.WriteFile(fms.getMountFilename(mount, "init-id"), []byte(init), 0644)
^
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
WARN [runner] The linter 'golint' is deprecated (since v1.41.0) due to: The repository of the linter has been archived by the owner. Replaced by revive. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
b0da8b5 to
c24a8ac
Compare
Member
|
I think the linter should be runnable(same way as it does in CI) without uploading a PR to github. An obvious choice for us would be to run it inside a container/Dockerfile. No objects to invoking that through github actions workflow then. |
Member
|
Closed as this is already done with the new actions CI on master/22.06 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test run can be seen on thaJeztah#3