Skip to content

Use docker media type for plugin layers#42210

Merged
thaJeztah merged 1 commit intomoby:masterfrom
cpuguy83:plugin_layer_mediatype
Apr 6, 2021
Merged

Use docker media type for plugin layers#42210
thaJeztah merged 1 commit intomoby:masterfrom
cpuguy83:plugin_layer_mediatype

Conversation

@cpuguy83
Copy link
Member

@cpuguy83 cpuguy83 commented Mar 26, 2021

This was changed as part of a refactor to use containerd dist code. The
problem is the OCI media types are not compatible with older versions of
Docker.

Closes #42191

@cpuguy83 cpuguy83 force-pushed the plugin_layer_mediatype branch from e700be4 to 3d682c3 Compare March 26, 2021 22:14
@cpuguy83 cpuguy83 added this to the 20.10.6 milestone Mar 26, 2021
@thaJeztah thaJeztah modified the milestones: 20.10.6, 21.xx Mar 26, 2021
thaJeztah
thaJeztah approved these changes Mar 26, 2021
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah mentioned this pull request Mar 29, 2021
Closed
@thaJeztah
Copy link
Member

thaJeztah commented Mar 29, 2021

@cpuguy83 looks like the test is failing;

=== RUN   TestPluginBackCompatMediaTypes
time="2021-03-26T22:28:30Z" level=error msg="Can't add file /tmp/create-test-plugin025773910/rootfs/basic to tar: io: read/write on closed pipe"
time="2021-03-26T22:28:30Z" level=error msg="Can't close tar writer: io: read/write on closed pipe"
--- FAIL: TestPluginBackCompatMediaTypes (0.13s)
    plugin_test.go:245: assertion failed: error is not nil: Error response from daemon: plugin 127.0.0.1:5000/testpluginbackcompatmediatypes:latest already exists

@thaJeztah thaJeztah added the status/failing-ci Indicates that the PR in its current state fails the test suite label Mar 29, 2021
@cpuguy83 cpuguy83 force-pushed the plugin_layer_mediatype branch from 3d682c3 to 43bbc2b Compare April 5, 2021 17:24
@cpuguy83
Copy link
Member Author

cpuguy83 commented Apr 5, 2021

Last push should take care of that test error.
Wasn't doing the test cleanup.

@thaJeztah
Copy link
Member

thaJeztah commented Apr 5, 2021

close; only rootless is failing now; but I see some other tests are skipped because "rootless has another view on localhost", so perhaps it means the tests need to be skipped on rootless

@cpuguy83
Use docker media type for plugin layers
a876ede 
This was changed as part of a refactor to use containerd dist code. The
problem is the OCI media types are not compatible with older versions of
Docker.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
@cpuguy83 cpuguy83 force-pushed the plugin_layer_mediatype branch from 43bbc2b to a876ede Compare April 5, 2021 21:47
@cpuguy83
Copy link
Member Author

cpuguy83 commented Apr 5, 2021

Good now.

@thaJeztah
Copy link
Member

thaJeztah commented Apr 6, 2021

Thanks! Remaining failure is a flaky test;

=== RUN   TestDockerSuite/TestRunInteractiveWithRestartPolicy
    --- FAIL: TestDockerSuite/TestRunInteractiveWithRestartPolicy (11.92s)
        docker_cli_run_test.go:1797: assertion failed: 
            Command:  /usr/local/cli/docker run -i --name test-inter-restart --restart=always busybox sh
            ExitCode: 0
            Stdout:   
            Stderr:   
            
            Failures:
            ExitCode was 0 expected 11

@thaJeztah thaJeztah merged commit 95bb41a into moby:master Apr 6, 2021
@cpuguy83 cpuguy83 deleted the plugin_layer_mediatype branch April 6, 2021 16:53
@cpuguy83 cpuguy83 mentioned this pull request Apr 6, 2021
Merged
@thaJeztah thaJeztah removed the status/failing-ci Indicates that the PR in its current state fails the test suite label Apr 6, 2021
@thaJeztah thaJeztah mentioned this pull request Apr 6, 2021
Closed
@thaJeztah thaJeztah mentioned this pull request Nov 17, 2021
Merged
@thaJeztah thaJeztah mentioned this pull request Mar 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@tiborvass tiborvass Awaiting requested review from tiborvass

Assignees

No one assigned

Labels

area/plugins kind/bugfix PR's that fix bugs process/cherry-picked status/2-code-review

Projects

None yet

Milestone

23.0.0

Development

Successfully merging this pull request may close these issues.

docker plugin create on 20.x version makes unusable plugins for 19.x/18.x/17.x

3 participants

@cpuguy83 @thaJeztah @tonistiigi