Remove cli test for duplicate --net/--network opts #42163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be testing a strange case, specifically that one can set the `--net` and `--network` in the same command with the same network. Indeed this used to work with older CLIs but newer ones error out when validating the request before sending it to the daemon. Opening this for discussion because: 1. This doesn't seem to be testing anything at all related to the rest of the test 2. Not really providing any value here. 3. Is testing that a technically invalid option is successful (whether the option should be valid as it relates to the CLI accepting it is debatable). 4. Such a case seems fringe and even a bug in whatever is calling the CLI with such options. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
1083874 to
e310863
Compare
tonistiigi
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be testing a strange case, specifically that one can set
the
--netand--networkin the same command with the same network.Indeed this used to work with older CLIs but newer ones error out when
validating the request before sending it to the daemon.
Opening this for discussion because:
of the test
the option should be valid as it relates to the CLI accepting it is
debatable).
CLI with such options.
The change that caused this is from docker/cli#1767