[testing] fix TestBuildUserNamespaceValidateCapabilitiesAreV2 failures#41936
Merged
cpuguy83 merged 2 commits intomoby:masterfrom Feb 16, 2021
Merged
[testing] fix TestBuildUserNamespaceValidateCapabilitiesAreV2 failures#41936cpuguy83 merged 2 commits intomoby:masterfrom
cpuguy83 merged 2 commits intomoby:masterfrom
Conversation
0ef6ae1 to
1db571b
Compare
This comment has been minimized.
This comment has been minimized.
Member
Author
AkihiroSuda
approved these changes
Feb 4, 2021
This currently doesn't make a difference, because load.FrozenImagesLinux() currently loads all frozen images, not just the specified one, but in case that is fixed/implemented at some point. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
1db571b to
4d3702b
Compare
thaJeztah
commented
Feb 15, 2021
Comment on lines
72
to
73
Member
Author
There was a problem hiding this comment.
After discussing with @tonistiigi @tiborvass - updated this to use jsonmessage to detect errors (instead of checking for "Successfully built"
Possibly there's other tests that have this same issue (so something to look into in a follow-up)
thaJeztah
commented
Feb 15, 2021
4d3702b to
b043c98
Compare
Check if the `docker build` completed successfully before continuing. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
b043c98 to
fa48040
Compare
Member
Author
|
arm failure doesn't look related; some issue with Jenkins and ec2? |
Member
Author
Member
Author
|
jay; all green now (Jenkins was having some issues) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to #41925 (comment)
relates to #41927 (comment)
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)