[DNM] trigger CI with runc#2750 ("seccomp: prepend -ENOSYS stub to all filters)#41900
[DNM] trigger CI with runc#2750 ("seccomp: prepend -ENOSYS stub to all filters)#41900AkihiroSuda wants to merge 1 commit intomoby:masterfrom
Conversation
|
This one seems failing consistently, though it doesn't really look related cc @cyphar |
c8e0db1 to
3dccb96
Compare
|
I took a look at the failing test. I think it's an issue with updating runc than with the seccomp change -- the test in question assumes that the top-most layer will just contain My guess is we just want a patch like the following added to the test: diff --git a/integration-cli/docker_cli_save_load_test.go b/integration-cli/docker_cli_save_load_test.go
index 5f32d1c1d2b8..348b676f6285 100644
--- a/integration-cli/docker_cli_save_load_test.go
+++ b/integration-cli/docker_cli_save_load_test.go
@@ -283,7 +283,6 @@ func (s *DockerSuite) TestSaveDirectoryPermissions(c *testing.T) {
found := false
for _, entry := range dirs {
- var entriesSansDev []string
if entry.IsDir() {
layerPath := filepath.Join(extractionDirectory, entry.Name(), "layer.tar")
@@ -293,14 +292,19 @@ func (s *DockerSuite) TestSaveDirectoryPermissions(c *testing.T) {
defer f.Close()
entries, err := listTar(f)
+ assert.NilError(c, err, "encountered error while listing tar entries: %s", err)
+
+ var entriesSansBuiltin []string
for _, e := range entries {
- if !strings.Contains(e, "dev/") {
- entriesSansDev = append(entriesSansDev, e)
+ // Filter out built-in directories added to layers (like /dev
+ // inodes and /tmp tmpfs) since those may change if our default
+ // config changes.
+ if !strings.Contains(e, "dev/") && e != "tmp/" {
+ entriesSansBuiltin = append(entriesSansBuiltin, e)
}
}
- assert.NilError(c, err, "encountered error while listing tar entries: %s", err)
- if reflect.DeepEqual(entriesSansDev, layerEntries) || reflect.DeepEqual(entriesSansDev, layerEntriesAUFS) {
+ if reflect.DeepEqual(entriesSansBuiltin, layerEntries) || reflect.DeepEqual(entriesSansBuiltin, layerEntriesAUFS) {
found = true
break
}I don't see how the seccomp change specifically would trigger this. |
|
Moby CI with opencontainers/runc@c69ae75 (master, Jan 22) + f266f13 was passing |
This comment has been minimized.
This comment has been minimized.
|
Oh I just figured out what it was while writing the above comment (and it took me way too long to realise this) -- it's because I created a temporary file in |
|
Yup, with the latest commits the test no longer fails. |
3dccb96 to
f063ca3
Compare
|
Sorry, I pushed a new commit you'll need to rebase this. |
…l filters") Testing compatibility of opencontainers/runc#2750 . Commits: https://github.com/cyphar/runc/commits/seccomp-patched-bpf DO NOT MERGE. Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
f063ca3 to
6f3384c
Compare
|
The runc PR is now merged, thanks @cyphar ! |
Testing compatibility of opencontainers/runc#2750 .
Commits: https://github.com/cyphar/runc/commits/seccomp-patched-bpf
DO NOT MERGE.