Fix Error in daemon_unix.go and docker_cli_run_unit_test.go#41857
Merged
cpuguy83 merged 1 commit intomoby:masterfrom Jan 5, 2021
Merged
Fix Error in daemon_unix.go and docker_cli_run_unit_test.go#41857cpuguy83 merged 1 commit intomoby:masterfrom
cpuguy83 merged 1 commit intomoby:masterfrom
Conversation
Signed-off-by: gunadhya <6939749+gunadhya@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: gunadhya 6939749+gunadhya@users.noreply.github.com
fixes #41852
- What I did
moby/integration-cli/docker_cli_run_unix_test.go
Line 700 in 4d6bc59
moby/daemon/daemon_unix.go
Line 464 in 8891c58
Fixed the error message as requested #41852 (comment)
- How I did it
Changed the error message from 4MB to 6MB
- How to verify it
gunadhya@64465f3
- Description for the changelog
error message stating the minimum memory reservation allowed is changed from 4MB to 6MB
- A picture of a cute animal (not mandatory but encouraged)