Also trim "~..." from AppArmor versions#41537
Merged
AkihiroSuda merged 1 commit intomoby:masterfrom Oct 9, 2020
Merged
Conversation
Member
|
Can we have a unit test? |
Signed-off-by: Tianon Gravi <admwiggin@gmail.com>
Member
Author
|
Great point, updated 👍 |
AkihiroSuda
approved these changes
Oct 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Asked Canonical (who in turn had spoken to AppArmor upstream maintainers) whether we needed to trim
~...from AppArmor versions too (#41518 (comment)). 😄- How I did it
I found https://gitlab.com/apparmor/apparmor/-/commit/bca67d3d27d219d11ce8c9cc70612bd637f88c10 as a good example of the historical
~versions, and copied the implementation of #41518 to also trim~.... 😄- How to verify it
Go back in time to AppArmor
2.7.0~rc2🤔- A picture of a cute animal (not mandatory but encouraged)