Skip to content

seccomp: remove dependency on oci package#41500

Merged
thaJeztah merged 2 commits intomoby:masterfrom
thaJeztah:seccomp_separate
Sep 29, 2020
Merged

seccomp: remove dependency on oci package#41500
thaJeztah merged 2 commits intomoby:masterfrom
thaJeztah:seccomp_separate

Conversation

@thaJeztah
Copy link
Member

follow-up to #41471 and #41499

@thaJeztah thaJeztah marked this pull request as ready for review September 28, 2020 19:42
@thaJeztah
Copy link
Member Author

@tonistiigi @tiborvass PTAL

rewrite the tests to use a minimal runtime-spec Spec instead

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

@tonistiigi updated, PTAL

@thaJeztah
Copy link
Member Author

Arf, missing a build-tag; windows failed, but doesn't report correctly https://ci-next.docker.com/public/job/moby/job/PR-41500/3/display/redirect 😞

[2020-09-29T17:52:04.683Z] === Errors
[2020-09-29T17:52:04.683Z] oci\seccomp_test.go:21:17: undefined: seccomp.LoadProfile
[2020-09-29T17:52:04.683Z] oci\seccomp_test.go:29:25: undefined: seccomp.DefaultProfile
[2020-09-29T17:52:04.683Z] oci\seccomp_test.go:34:15: undefined: seccomp.LoadProfile

Verify that we're able to test seccomp profiles with our
default Spec.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

Fixed

@thaJeztah thaJeztah merged commit 46cdcd2 into moby:master Sep 29, 2020
@thaJeztah thaJeztah deleted the seccomp_separate branch September 29, 2020 20:11
@thaJeztah thaJeztah added this to the 20.03.0 milestone Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants