Windows CI: Fix collecting the logs of the daemon under test#41463
Merged
thaJeztah merged 1 commit intomoby:masterfrom Sep 19, 2020
Merged
Windows CI: Fix collecting the logs of the daemon under test#41463thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
Signed-off-by: Stefan Scherer <stefan.scherer@docker.com>
2cdbaa1 to
89bec2e
Compare
Contributor
|
SGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
This PR fixes an issue we discussed in #40599. Sometimes the logs of the daemon under test couldn't be found.
- How I did it
I first ran a test to show me the current dir in the script, and indeed in some cases the script was a sub folder, and the Copy-Item silently continues if the target folder doesn't exist.
- How to verify it
The Windows builds should now always have artifacts with the CIDUT.out / CIDUT.err files in it.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)