Wait for container exit before forcing handler#41341
Merged
AkihiroSuda merged 1 commit intomoby:masterfrom Aug 13, 2020
Merged
Conversation
This code assumes that we missed an exit event since the container is still marked as running in Docker but attempts to signal the process in containerd returns a "process not found" error. There is a case where the event wasn't missed, just that it hasn't been processed yet. This change tries to work around that possibility by waiting to see if the container is eventually marked as stopped. It uses the container's configured stop timeout for this. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
a75ed95 to
7fd2334
Compare
Member
|
@tonistiigi PTAL |
AkihiroSuda
approved these changes
Aug 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code assumes that we missed an exit event since the container is
still marked as running in Docker but attempts to signal the process in
containerd returns a "process not found" error.
There is a case where the event wasn't missed, just that it hasn't been
processed yet.
This change tries to work around that possibility by waiting to see if
the container is eventually marked as stopped. It uses the container's
configured stop timeout for this.
Fixes #41338