Skip to content

[19.03 backport] vendor: vishvananda/netns db3c7e526aae966c4ccfa6c8189b693d6ac5d202#41287

Merged
tiborvass merged 2 commits intomoby:19.03from
thaJeztah:19.03_backport_bump_netns
Jul 31, 2020
Merged

[19.03 backport] vendor: vishvananda/netns db3c7e526aae966c4ccfa6c8189b693d6ac5d202#41287
tiborvass merged 2 commits intomoby:19.03from
thaJeztah:19.03_backport_bump_netns

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

backport of #41283. Added one extra commit to account for the netns bump not in 19.03 from e26e1cc (#40683)

full diff: vishvananda/netns@0a2b9b5...db3c7e5

- Description for the changelog

…02f7e

Same update as was vendored in e26e1cc on
master.

full diff: vishvananda/netns@7109fa8...0a2b9b5

- Add support for Go modules

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
full diff: vishvananda/netns@0a2b9b5...db3c7e5

- Use golang.org/x/sys/unix instead of syscall
- Set O_CLOEXEC when opening a network namespace
    - Fixes "the container‘s netns fds leak, causing the container netns to not
      clean up successfully after the container stops"
- Allows to create and delete named network namespaces

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 818bad6)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Copy Markdown
Member Author

@arkodg @cpuguy83 @tiborvass PTAL

Copy link
Copy Markdown
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiborvass tiborvass merged commit 88820a4 into moby:19.03 Jul 31, 2020
@thaJeztah thaJeztah deleted the 19.03_backport_bump_netns branch July 31, 2020 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants