[19.03 backport] vendor: hcsshim 9dcb42f100215f8d375b4a9265e5bba009217a85#41192
Merged
AkihiroSuda merged 2 commits intomoby:19.03from Jul 10, 2020
Merged
[19.03 backport] vendor: hcsshim 9dcb42f100215f8d375b4a9265e5bba009217a85#41192AkihiroSuda merged 2 commits intomoby:19.03from
AkihiroSuda merged 2 commits intomoby:19.03from
Conversation
full diff: microsoft/hcsshim@v0.8.7...v0.8.9 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 08d3774) Signed-off-by: Ameya Gawde <agawde@mirantis.com>
This change brings in a single new commit from Microsoft/hcsshim. The commit fixes an issue when unpacking a Windows container layer which could result in incorrect directory timestamps. This manifested most significantly in an impact to startup times of some Windows container images (such as anything based on servercore). Signed-off-by: Kevin Parsons <kevpar@microsoft.com> (cherry picked from commit 2865478) Signed-off-by: Ameya Gawde <agawde@mirantis.com>
Member
|
@cpuguy83 PTAL |
cpuguy83
approved these changes
Jul 9, 2020
Member
cpuguy83
left a comment
There was a problem hiding this comment.
Reviewed all the changes.
The majority of it seems to be to add context.Context support, and then tracing/logging changes (lots of logging replaced by tracing).
LGTM
AkihiroSuda
approved these changes
Jul 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick:
Fixes #41066
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)