[19.03 backport] Fix bug in gotestsum installer causing dependencies to not be downloaded#40988
Merged
tiborvass merged 1 commit intomoby:19.03from May 19, 2020
Conversation
Building gotestsum started to fail after the repository removed some
dependencies on master.
What happens is that first, we `go get` the package (with go modules disabled);
GO111MODULE=off go get -d gotest.tools/gotestsum
Which gets the latest version from master, and fetches the dependencies used
on master. Then we checkout the version we want to install (for example `v0.3.5`)
and run go build.
However, `v0.3.5` depends on logrus, and given that we ran `go get` for `master`,
that dependency was not fetched, and build fails.
This patch modifies the installer to use go modules (alternatively we could
probably run `go get .` after checking out the `v0.3.5` version),
We need to modify all installers, as it looks like this is a standard pattern
we use, but other dependencies were not failing (yet), so this patch only
addresses the immediate failure.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 1d9da1b)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
AkihiroSuda
approved these changes
May 17, 2020
tiborvass
approved these changes
May 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of the Linux-related changes of #40979
the Windows Dockerfile in the 19.03 branch does not yet install gotestsum, so no changes were needed for Windows
Building gotestsum started to fail after the repository removed some
dependencies on master.
What happens is that first, we
go getthe package (with go modules disabled);Which gets the latest version from master, and fetches the dependencies used
on master. Then we checkout the version we want to install (for example
v0.3.5)and run go build.
However,
v0.3.5depends on logrus, and given that we rango getformaster,that dependency was not fetched, and build fails.
This patch modifies the installer to use go modules (alternatively we could
probably run
go get .after checking out thev0.3.5version),We need to modify all installers, as it looks like this is a standard pattern
we use, but other dependencies were not failing (yet), so this patch only
addresses the immediate failure.