Skip to content

[do not merge] vendor libnetwork with firewalld changes#40933

Closed
thaJeztah wants to merge 1 commit intomoby:masterfrom
thaJeztah:test_libnetwork
Closed

[do not merge] vendor libnetwork with firewalld changes#40933
thaJeztah wants to merge 1 commit intomoby:masterfrom
thaJeztah:test_libnetwork

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented May 8, 2020

This is just to have a CI run with the changes made in the libnetwork PR (moby/libnetwork#2548). We don't run firewalld in our CI, but making sure there's no regressions otherwise.

/cc @arkodg @cpuguy83

@thaJeztah
[do not merge] vendor libnetwork with firewalld changes
1226384 
This is just to have a CI run with the changes made in the libnetwork PR

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added the area/networking Networking label May 8, 2020
@arkodg
Copy link
Contributor

arkodg commented May 8, 2020

failure looks unrelated

=== RUN   TestJSONFileLoggerWithOpts
--- FAIL: TestJSONFileLoggerWithOpts (0.01s)
    jsonfilelog_test.go:187: open C:\Users\ContainerAdministrator\AppData\Local\Temp\docker-logger-432409777\container.log.1: The process cannot access the file because it is being used by another process.

@cpuguy83
Copy link
Member

cpuguy83 commented May 8, 2020

What can we do to get a CI machine with firewalld?

@cpuguy83
Copy link
Member

cpuguy83 commented May 8, 2020

Probably doesn't need to run on every PR, just master run.

@arkodg
Copy link
Contributor

arkodg commented May 8, 2020

@StefanScherer would it be possible to setup a Centos8/Fedora32 CI machine with firewalld enabled, this will also help with the ongoing work to support docker-ce packages for the above distros
TIA :)

@StefanScherer
Copy link
Contributor

StefanScherer commented May 9, 2020

Yes, we could add CentOS 8 CI agents, demoed in a PoC, we‘re discussing the details internally.

@arkodg
Copy link
Contributor

arkodg commented May 9, 2020

@thaJeztah mentioned that the integration tests run in DinD which cannot be used to test firewalld integration

@cpuguy83
Copy link
Member

cpuguy83 commented May 9, 2020 via email

@thaJeztah thaJeztah mentioned this pull request Jul 8, 2020
Merged
@thaJeztah thaJeztah deleted the test_libnetwork branch July 13, 2020 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianon tianon Awaiting requested review from tianon tianon will be requested when the pull request is marked ready for review tianon is a code owner

Assignees

No one assigned

Labels

area/networking Networking

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah @arkodg @cpuguy83 @StefanScherer