Skip to content

[19.03 backport] Move schema1 deprecation notice#40681

Merged
thaJeztah merged 1 commit intomoby:19.03from
thaJeztah:19.03_backport_schema2v1_dep_notice_on_error_only
Apr 2, 2020
Merged

[19.03 backport] Move schema1 deprecation notice#40681
thaJeztah merged 1 commit intomoby:19.03from
thaJeztah:19.03_backport_schema2v1_dep_notice_on_error_only

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

backport of #40671
fixes docker/for-linux#942 for 19.03

Currently we show this deprecation notice for any error returned by a
registry.
Registries can return an error for any number of reasons.
Instead let's show the deprecation notice only if the fallback was
successful.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Currently we show this deprecation notice for any error returned by a
registry.
Registries can return an error for any number of reasons.
Instead let's show the deprecation notice only if the fallback was
successful.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
(cherry picked from commit 6859bc7)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added area/distribution Image Distribution status/2-code-review kind/bugfix PR's that fix bugs labels Mar 12, 2020
@thaJeztah thaJeztah added this to the 19.03.9 milestone Mar 12, 2020
Copy link
Copy Markdown
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 5ed8f9a into moby:19.03 Apr 2, 2020
@thaJeztah thaJeztah deleted the 19.03_backport_schema2v1_dep_notice_on_error_only branch April 2, 2020 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/distribution Image Distribution kind/bugfix PR's that fix bugs status/4-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants