daemon/cluster: add a missing Unlock#40594
Merged
cpuguy83 merged 1 commit intomoby:masterfrom Feb 28, 2020
Merged
Conversation
Signed-off-by: Ziheng Liu <lzhfromustc@gmail.com>
AkihiroSuda
approved these changes
Feb 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
The following code has a missing Unlock:
moby/daemon/cluster/swarm.go
Lines 32 to 38 in 9fee52d
This PR adds an Unlock before return with error.
- How to verify it
We checked other places where this RWMutex is used, and Lock is always followed with Unlock in control-flow-graph, except in this place.
- Description for the changelog
Adds a missing Unlock before return with error.
- A picture of a cute animal (not mandatory but encouraged)
🐷