Skip to content

[19.03] vendor: update buildkit v0.6.4#40557

Merged
thaJeztah merged 1 commit intomoby:19.03from
thaJeztah:19.03_bump_buildkit_v0.6.4
Feb 24, 2020
Merged

[19.03] vendor: update buildkit v0.6.4#40557
thaJeztah merged 1 commit intomoby:19.03from
thaJeztah:19.03_bump_buildkit_v0.6.4

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

full diff: moby/buildkit@57e8ad5...v0.6.4

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

full diff: moby/buildkit@57e8ad5...v0.6.4

- buildkit#1374 [v0.6] ops: fix deadlock on releasing shared mounts
    - backport of buildkit#1355 ops: fix deadlock on releasing shared mounts
    - fixes buildkit#1322 Deadlock on cache mounts

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Copy Markdown
Member Author

ping @tonistiigi @cpuguy83 PTAL

Copy link
Copy Markdown
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Copy Markdown
Member Author

Flaky test on Windows (seen it fail a while back on s390x; possibly if the machine is slow);

[2020-02-22T11:58:13.188Z] --- FAIL: TestStateTimeoutWait (0.24s)
[2020-02-22T11:58:13.189Z]     state_test.go:137: Stop callback doesn't fire in 200 milliseconds
[2020-02-22T11:58:13.189Z] FAIL

It's not failing often, but leaving a comment in case it starts to occur more frequently.

@thaJeztah
Copy link
Copy Markdown
Member Author

ping @tonistiigi PTAL

@thaJeztah
Copy link
Copy Markdown
Member Author

bringing this one in

@thaJeztah thaJeztah merged commit 5e6469c into moby:19.03 Feb 24, 2020
@thaJeztah thaJeztah deleted the 19.03_bump_buildkit_v0.6.4 branch February 24, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants