Skip to content

[19.03 backport] vendor: update opencontainers/selinux v1.3.1#40547

Merged
AkihiroSuda merged 1 commit intomoby:19.03from
thaJeztah:19.03_backport_update_selinux_v1.3.1
Feb 25, 2020
Merged

[19.03 backport] vendor: update opencontainers/selinux v1.3.1#40547
AkihiroSuda merged 1 commit intomoby:19.03from
thaJeztah:19.03_backport_update_selinux_v1.3.1

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

full diff: opencontainers/selinux@5215b18...v1.3.1

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 12c7541)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Copy link
Copy Markdown
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda AkihiroSuda merged commit a515a32 into moby:19.03 Feb 25, 2020
@thaJeztah thaJeztah deleted the 19.03_backport_update_selinux_v1.3.1 branch February 25, 2020 08:45
@RobbKistler
Copy link
Copy Markdown

@thaJeztah I'm tracking down an SELinux issue in moby/moby somewhere between 19.03.5 and 19.03.8. The full diff of the opencontainers is much larger than this vendoring change -- is that just because the vendoring only only pulling in a subset of the files?

@thaJeztah
Copy link
Copy Markdown
Member Author

@RobbKistler correct; vndr pulls in only the parts of a dependency that we use (granularity is per "directory" / "package"). Any part that's not pulled in, is not used in our code base

@thaJeztah
Copy link
Copy Markdown
Member Author

if you install an older version of the engine (and/or containerd+runc) the issue doesn't reproduce? It's also possible things changed in the containers-selinux package (we've had issues with that in the past)

@thaJeztah
Copy link
Copy Markdown
Member Author

@RobbKistler I think your question relates to #40944, let's continue there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants