Dockerfile: also build old registry on armhf, and small optimization#40362
Merged
thaJeztah merged 2 commits intomoby:masterfrom Jan 10, 2020
Merged
Dockerfile: also build old registry on armhf, and small optimization#40362thaJeztah merged 2 commits intomoby:masterfrom
thaJeztah merged 2 commits intomoby:masterfrom
Conversation
Building the old version of the registry is not supported on arm64, but building on armhf is possible. Before using a multi-arch Dockerfile, the registry was built on armhf as well, but this got lost in the transition in commit f1701a7. This commit re-enables building the old registry on armhf. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
3 tasks
tonistiigi
approved these changes
Jan 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extracted from #40094
Dockerfile: also build old registry on armhf
Building the old version of the registry is not supported
on arm64, but building on armhf is possible.
Before using a multi-arch Dockerfile, the registry was
built on armhf as well, but this got lost in the transition
in commit f1701a7.
This commit re-enables building the old registry on armhf.
Dockerfile: use tmpfs for building registry, go-swagger
Simplifies the build-stages, and doesn't require the temporary directory to be removed afterwards