prevent panic if TINI_COMMIT isn't set during build#40361
Merged
cpuguy83 merged 1 commit intomoby:masterfrom Jan 10, 2020
Merged
prevent panic if TINI_COMMIT isn't set during build#40361cpuguy83 merged 1 commit intomoby:masterfrom
cpuguy83 merged 1 commit intomoby:masterfrom
Conversation
If TINI_COMMIT isn't set, .go-autogen sets an empty value as the "expected" commit. Attempting to truncate the value caused a panic in that situation. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
118709c to
339fb74
Compare
AkihiroSuda
approved these changes
Jan 10, 2020
cpuguy83
approved these changes
Jan 10, 2020
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extracted from #40094
If
TINI_COMMITisn't set,.go-autogensets an empty value as the "expected" commit. Attempting to truncate the value caused a panic in that situation.