bump vndr v0.1.0 to support versioned import paths#40359
Merged
cpuguy83 merged 1 commit intomoby:masterfrom Jan 10, 2020
Merged
bump vndr v0.1.0 to support versioned import paths#40359cpuguy83 merged 1 commit intomoby:masterfrom
cpuguy83 merged 1 commit intomoby:masterfrom
Conversation
With this change, go packages/modules that use versioned import paths (github.com/foo/bar/v2), but don't use a directory in the repository, can now be supported. For example: ``` github.com/coreos/go-systemd/v22 v22.0.0 ``` will vendor the github.com/coreos/go-systemd repository into `vendor/github.com/coreos/go-systemd/v22`. full diff: LK4D4/vndr@f5ab8fc...v0.1.0 - LK4D4/vndr#83 migrate bitbucket to api 2.0 - fixes LK4D4/vndr#82 https://api.bitbucket.org/1.0/repositories/ww/goautoneg: 410 Gone - LK4D4/vndr#86 Replace sort.Sort with sort.Strings - LK4D4/vndr#87 support `github.com/coreos/go-systemd/v22` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
@cpuguy83 @AkihiroSuda ptal |
Member
Author
|
trigged jenkins with the "force-validate" option to force running vendor-check |
AkihiroSuda
approved these changes
Jan 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, go packages/modules that use versioned
import paths (github.com/foo/bar/v2), but don't use a directory
in the repository, can now be supported.
For example:
will vendor the github.com/coreos/go-systemd repository
into
vendor/github.com/coreos/go-systemd/v22.full diff: LK4D4/vndr@f5ab8fc...v0.1.0
github.com/coreos/go-systemd/v22LK4D4/vndr#87 supportgithub.com/coreos/go-systemd/v22