Add RequestAck property to fluentd logger#40332
Closed
herewasmike wants to merge 1 commit intomoby:masterfrom
herewasmike:add_request_ack_option_fluentd
Closed
Add RequestAck property to fluentd logger#40332herewasmike wants to merge 1 commit intomoby:masterfrom herewasmike:add_request_ack_option_fluentd
herewasmike wants to merge 1 commit intomoby:masterfrom
herewasmike:add_request_ack_option_fluentd
Conversation
Signed-off-by: Mike Toldov <matoldov@gmail.com>
Member
|
Think this is also included in #39086 (but not merged yet) |
Author
|
Yeah, it is, didn't find it. |
Member
|
I just rebased the other one and pinged some maintainers; hopefully someone will review and merge it soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fluent-logger-golang supports RequestAck property.
https://github.com/fluent/fluent-logger-golang#requestack
It would be nice to have an opportunity to use it with fluentd log-driver.
- Description for the changelog
Add RequestAck property to fluentd logger
- A picture of a cute animal (not mandatory but encouraged)
