Skip to content

AppArmor: add missing rules for running in userns#39992

Merged
AkihiroSuda merged 1 commit intomoby:masterfrom
thaJeztah:apparmor_fix_network_paths
Oct 12, 2019
Merged

AppArmor: add missing rules for running in userns#39992
AkihiroSuda merged 1 commit intomoby:masterfrom
thaJeztah:apparmor_fix_network_paths

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Sep 26, 2019 •
edited
Loading

built on top of #39991 (I'll rebase once that's merged) rebased

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Sep 26, 2019

ping @justincormack @AkihiroSuda @estesp PTAL

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Sep 30, 2019 •
edited
Loading

Looks like this test is flaky (mostly on s390x?); last change in that test was #39881

=== RUN TestInspect
--- FAIL: TestInspect (11.91s)
inspect_test.go:23: Creating a new daemon at: "/go/src/github.com/docker/docker/bundles/test-integration/TestInspect"
inspect_test.go:39: timeout hit after 10s: waiting for tasks to enter run state. task failed with error: task: non-zero exit (1)

@thaJeztah
AppArmor: add missing rules for running in userns
404d87e 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the apparmor_fix_network_paths branch from 82c4f5c to 404d87e Compare September 30, 2019 14:17
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Sep 30, 2019

rebased, because #39991 was merged

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Sep 30, 2019

Probably not, but I recalled there were issues with networking and userns, so wondered if there was a relation with #26106. Mentioning it, just in case there is a relation 😅

@crosbymichael
Copy link
Copy Markdown
Contributor

crosbymichael commented Oct 1, 2019

LGTM

@thaJeztah thaJeztah added the kind/bugfix PR's that fix bugs label Oct 10, 2019
@AkihiroSuda AkihiroSuda merged commit d1e837d into moby:master Oct 12, 2019
@thaJeztah thaJeztah deleted the apparmor_fix_network_paths branch October 12, 2019 20:50
@thaJeztah thaJeztah mentioned this pull request Feb 22, 2020
Merged
@thaJeztah thaJeztah added this to the 20.03.0 milestone Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

area/security/apparmor area/security/userns area/security kind/bugfix PR's that fix bugs process/cherry-picked status/2-code-review

Projects

None yet

Milestone

20.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@thaJeztah @crosbymichael @AkihiroSuda