@thaJeztah While we are here, I noticed that the "Accept change" button seems to not work. I was pleasantly surprised to see it there and used it. And got an error message that my commit is not signed. Could I have done something to include my signatures there [or better yet could they have been included automatically]?

Not only that but the suggested steps for working around the signing issue did not help either. Not sure which forum to raise those in - I can delete these comments here later if this is not a good place to bring these up but for now I will document it here:

C:\gopath\src\github.com\moby\moby>git commit --amend --signoff
[disable_TestPsListContainersFilterExited_on_windows b6e3392929] Disable TestPsListContainersFilterExited (Windows)
Date: Tue Sep 17 22:10:54 2019 +0000
1 file changed, 4 insertions(+)

C:\gopath\src\github.com\moby\moby>
C:\gopath\src\github.com\moby\moby>git push --force-with-lease origin disable_TestPsListContainersFilterExited_on_windows
remote: Permission to moby/moby.git denied to vikramhh.
fatal: unable to access 'https://github.com/moby/moby.git/': The requested URL returned error: 403

C:\gopath\src\github.com\moby\moby>git push --force-with-lease upstream disable_TestPsListContainersFilterExited_on_windows
To https://github.com/vikramhh/moby.git
! [rejected] disable_TestPsListContainersFilterExited_on_windows -> disable_TestPsListContainersFilterExited_on_windows (stale info)
error: failed to push some refs to 'https://github.com/vikramhh/moby.git'

sorry didn't see your comments; i'll try to write down the steps when I'm back at my computer

rebased and squashed;

these were the steps I took;

Make sure my remotes are up to date;

git fetch --all

Start an interactive rebase

git rebase -i -s upstream/master

Which opens an editor;

pick b3ba166560 Disable TestPsListContainersFilterExited (Windows)
pick 9ffc8da716 Update integration-cli/docker_cli_ps_test.go

Change the second pick to s (squash)

pick b3ba166560 Disable TestPsListContainersFilterExited (Windows)
s 9ffc8da716 Update integration-cli/docker_cli_ps_test.go

Cleanup the commit message, save, and close your editor

Rebasing (2/2)
[detached HEAD 7de4e13089] Disable TestPsListContainersFilterExited (Windows)
 Author: Vikram bir Singh <vikrambir.singh@docker.com>
 Date: Tue Sep 17 22:10:54 2019 +0000
 1 file changed, 4 insertions(+)
Successfully rebased and updated refs/heads/vikramhh-disable_TestPsListContainersFilterExited_on_windows.

Force push your changes (assuming the remote pointing to your fork is named origin);

git push -f origin

ping @tiborvass @cpuguy83 ptal

@thaJeztah - thanks for squashing the commit. Any idea why we ended up in this state? My expectation was that if I "accepted" your comments, it will commit with the -s option on its own.

Yeah, the "suggestion" option isn't very useful for that; it will be a separate commit for each suggestion, and won't sign-off, so you'd always have to pull and squash afterwards