pkg/parsers/kernel: gofmt hex value (preparation for Go 1.13+)#39883
Merged
tiborvass merged 1 commit intomoby:masterfrom Sep 10, 2019
Merged
pkg/parsers/kernel: gofmt hex value (preparation for Go 1.13+)#39883tiborvass merged 1 commit intomoby:masterfrom
tiborvass merged 1 commit intomoby:masterfrom
Conversation
Member
Author
|
ping @kolyshkin @tiborvass PTAL |
Member
Author
|
Looks like Test was updated in #39616 to fix the flakiness, but the interesting bit there is that the retry loop should have a 3 second sleep before retrying, but looking at the failure above, the test started (and failed) within a second, which means that |
This was referenced Sep 9, 2019
Member
Author
|
Opened #39885 to add more debugging to that test |
Member
Author
|
RS1 failing on #38521 |
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
365047d to
7663aeb
Compare
tiborvass
approved these changes
Sep 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(separating from #39549)