rootless: harden slirp4netns with mount namespace and seccomp#39840
Merged
thaJeztah merged 1 commit intomoby:masterfrom Sep 4, 2019
Merged
rootless: harden slirp4netns with mount namespace and seccomp#39840thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
When slirp4netns v0.4.0+ is used, now slirp4netns is hardened using
mount namespace ("sandbox") and seccomp to mitigate potential
vulnerabilities.
bump up rootlesskit: rootless-containers/rootlesskit@2fcff6c...791ac8c
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
thaJeztah
approved these changes
Sep 2, 2019
Member
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM, but left a comment/thought
| exec $rootlesskit \ | ||
| --net=$net --mtu=$mtu \ | ||
| --slirp4netns-sandbox=$DOCKERD_ROOTLESS_ROOTLESSKIT_SLIRP4NETNS_SANDBOX \ | ||
| --slirp4netns-seccomp=$DOCKERD_ROOTLESS_ROOTLESSKIT_SLIRP4NETNS_SECCOMP \ |
Member
There was a problem hiding this comment.
What is the default if no auto is set? If we omit these flags, would it not use sandbox or seccomp?
Basically wondering if we need the DOCKERD_ROOTLESS_ROOTLESSKIT_SLIRP4NETNS_SANDBOX env-vars or if we should omit these flags in the script (assuming people install the latest version of rootless kit)
Member
Author
There was a problem hiding this comment.
The rootlesskit default value is currently false but planned to be auto in future https://github.com/rootless-containers/rootlesskit/blob/v0.7.0/cmd/rootlesskit/main.go#L63-L72
Member
There was a problem hiding this comment.
Ah, thanks for explaining; yes, auto sounds like a better default
Member
|
CI failure was unrelated; kicked Jenkins |
Member
|
Janky failure looks like a flaky test (tracked through #23626) https://ci.docker.com/public/job/moby/job/PR-39840/3/execution/node/178/log/?consoleFull |
Member
|
Merging this one, because I don't think any of this runs in CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Akihiro Suda akihiro.suda.cz@hco.ntt.co.jp
- What I did
When slirp4netns v0.4.0+ is used, now slirp4netns is hardened using
mount namespace ("sandbox") and seccomp to mitigate potential
vulnerabilities.
- How I did it
bump up rootlesskit: rootless-containers/rootlesskit@2fcff6c...791ac8c
- How to verify it
Run rootless mode with slirp4netns v0.4.0+ installed
- Description for the changelog
rootless: harden slirp4netns with mount namespace and seccomp
- A picture of a cute animal (not mandatory but encouraged)
🐧