integration: windows.ps1: turn defender error into a warning#39804
Merged
kolyshkin merged 1 commit intomoby:masterfrom Sep 2, 2019
Merged
integration: windows.ps1: turn defender error into a warning#39804kolyshkin merged 1 commit intomoby:masterfrom
kolyshkin merged 1 commit intomoby:masterfrom
Conversation
Member
Author
|
Looks like Windows RS1 took longer than 2 hours, and was killed |
Some integration tests are known to fail if Windows Defender is enabled. On the machines that run our CI, defender is disabled for that reason. Contributors likely will have defender enabled, and because of that are currently not able to run the integration tests. This patch changes the ERROR into a WARNING, so that contributors can still run (a limited set of) the integration tests, but get informed that some may fail. We should make this requirement more specific, and only skip tests that are known to require defender to be disabled, but while that's not yet in place, let's print a warning instead. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
0bb3389 to
3188518
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #39747 (comment) / #39747 (comment)
Some integration tests are known to fail if Windows Defender is
enabled. On the machines that run our CI, defender is disabled
for that reason.
Contributors likely will have defender enabled, and because of
that are currently not able to run the integration tests.
This patch changes the ERROR into a WARNING, so that contributors
can still run (a limited set of) the integration tests, but get
informed that some may fail.
We should make this requirement more specific, and only skip
tests that are known to require defender to be disabled, but
while that's not yet in place, let's print a warning instead.