integration: simplify parallel run destination#39802
Merged
tiborvass merged 1 commit intomoby:masterfrom Sep 11, 2019
Merged
Conversation
Member
Author
|
@kolyshkin @tiborvass PTAL |
tiborvass
reviewed
Aug 28, 2019
hack/make/test-integration
Outdated
Contributor
There was a problem hiding this comment.
I'm not even sure removing this is supposed to work.
Member
Author
Member
Author
There was a problem hiding this comment.
Wondering if the problem I ran into is somehow caused by 13df617
moby/hack/make/.integration-daemon-stop
Lines 13 to 14 in 13df617
Member
Author
There was a problem hiding this comment.
hm, or multiple containers mounting the same path, could unmounting (when the container is stopped) cause issues for another container mounting the same path?
39aaba2 to
e065fd9
Compare
'Namespace' parallel runs by bind-mounting a different directory in the container, instead of making the tests running inside the container aware of the namespaced location. This makes it transparent to the tests, and slightly reduces complexity. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
e065fd9 to
3262a69
Compare
1 task
Contributor
|
I talked with @thaJeztah about this and I think this should help to simplify the isolation. cc @tiborvass |
seemethere
approved these changes
Sep 11, 2019
tiborvass
approved these changes
Sep 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
splitting this one from #39724 as well, hopefully to make the other PR easier to review
'Namespace' parallel runs by bind-mounting a different directory
in the container, instead of making the tests running inside
the container aware of the namespaced location.
This makes it transparent to the tests, and slightly reduces
complexity.
This change fixes the problem I ran into in #39724 (comment):
Hm; looks like there's still an issue (at least with the uploaded bundles); with debug enabled, I see that these tests are run. Which means that we should have in total 18 go-test-report.json files, and 18 junit-report.xml files.
However, in the "janky" bundle, I only see; 8 JSON files, and 6 XML files, so either the
findis incorrect, or somewhere we purge files, or files are stored somewhere nested and therefore not found?All files are present in the PowerPC and s390x bundles, so I suspect that it's either because the path is different for the Janky run (they use the
1/,2/,3/` subdirectories, or perhaps there's an issue because of the test-flags (it's weird though, because for some tests the XML is there, but the JSON is missing, and vice-versa)