Skip to content

fix docker rmi stucking#39749

Merged
yongtang merged 1 commit intomoby:masterfrom
yanghaichao12:dev190815
Aug 20, 2019
Merged

fix docker rmi stucking#39749
yongtang merged 1 commit intomoby:masterfrom
yanghaichao12:dev190815

Conversation

@yanghaichao12
Copy link
Copy Markdown
Contributor

@yanghaichao12 yanghaichao12 commented Aug 15, 2019 •
edited by kolyshkin
Loading

Signed-off-by: Haichao Yang yang.haichao@zte.com.cn
fixes #39739

Fix docker rmi stuck in case of misconfigured system (such as dead NFS share).

  • A picture of a cute animal (not mandatory but encouraged)

@GordonTheTurtle GordonTheTurtle added the dco/no Automatically set by a bot when one of the commits lacks proper signature label Aug 15, 2019
@GordonTheTurtle
Copy link
Copy Markdown

GordonTheTurtle commented Aug 15, 2019

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "dev190815" git@github.com:yanghaichao12/moby.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@GordonTheTurtle GordonTheTurtle removed the dco/no Automatically set by a bot when one of the commits lacks proper signature label Aug 15, 2019
@yanghaichao12
Copy link
Copy Markdown
Contributor Author

yanghaichao12 commented Aug 15, 2019

/area images

1 similar comment
@yanghaichao12
Copy link
Copy Markdown
Contributor Author

yanghaichao12 commented Aug 15, 2019

/area images

@yanghaichao12
Copy link
Copy Markdown
Contributor Author

yanghaichao12 commented Aug 15, 2019

Derek add label: area/images

@yanghaichao12
Copy link
Copy Markdown
Contributor Author

yanghaichao12 commented Aug 15, 2019

/retest

@yanghaichao12
Copy link
Copy Markdown
Contributor Author

yanghaichao12 commented Aug 15, 2019

retest

1 similar comment
@yanghaichao12
Copy link
Copy Markdown
Contributor Author

yanghaichao12 commented Aug 15, 2019

retest

@yanghaichao12
Copy link
Copy Markdown
Contributor Author

yanghaichao12 commented Aug 15, 2019

retest this please

1 similar comment
@yanghaichao12
Copy link
Copy Markdown
Contributor Author

yanghaichao12 commented Aug 16, 2019

retest this please

@yanghaichao12
Copy link
Copy Markdown
Contributor Author

yanghaichao12 commented Aug 17, 2019

/retest

thaJeztah
thaJeztah requested changes Aug 17, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you; I left a comment below.

Could you also change your DCO sign-off to use your real name, not your GitHub handle (yanghaichao12)?

Signed-off-by: yanghaichao12 ....

.gitignore Outdated
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah Aug 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this change? It is not related to the fix, and we don't add editor-specific ignores here (see https://github.com/moby/moby/blob/d4306e4b331b49f086b9bec22421879c3e58072d/.gitignore#L1-L3)

@yanghaichao12
Copy link
Copy Markdown
Contributor Author

yanghaichao12 commented Aug 19, 2019

@thaJeztah hi, i have change DCO and remove the content in .gitignore added by me

@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Aug 19, 2019

Hm; perhaps something went wrong with the DCO sign-off; I still see this in the commit message 😅 ;

Signed-off-by: yanghaichao12 <yang.haichao@zte.com.cn>

@yanghaichao12
Copy link
Copy Markdown
Contributor Author

yanghaichao12 commented Aug 19, 2019

@thaJeztah hi， how about for now？

Signed-off-by: yanghaichao <yang.haichao@zte.com.cn>

@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Aug 19, 2019

It's one word, or Yang Haichao ?

Oh! 🙈 Looks like your local copy was out of date, and you pulled in an extra commit in the rebase. Can you rebase once more? (make sure your fork is up-to-date, and the extra commit should disappear)

@yanghaichao12 yanghaichao12 force-pushed the dev190815 branch 2 times, most recently from 2ccaf1c to d3f6484 Compare August 19, 2019 10:25
@yanghaichao12
Copy link
Copy Markdown
Contributor Author

yanghaichao12 commented Aug 19, 2019

in fact, Yang is my last name....., i have modified it

@yanghaichao12
fix docker rmi stucking
d3f6484 
Signed-off-by: Haichao Yang <yang.haichao@zte.com.cn>
thaJeztah
thaJeztah approved these changes Aug 19, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you! sorry for all the hassle with the sign-off 🤗

@yanghaichao12
Copy link
Copy Markdown
Contributor Author

yanghaichao12 commented Aug 19, 2019

thank you too :-)

@yanghaichao12
Copy link
Copy Markdown
Contributor Author

yanghaichao12 commented Aug 20, 2019

retest this please

@yanghaichao12
Copy link
Copy Markdown
Contributor Author

yanghaichao12 commented Aug 20, 2019

/retest

@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Aug 20, 2019

Windows RS1 failure is unrelated

@yongtang ptal 🤗

yongtang
yongtang approved these changes Aug 20, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@yongtang yongtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for the fix!

@yongtang yongtang merged commit d7b484c into moby:master Aug 20, 2019
@yanghaichao12
Copy link
Copy Markdown
Contributor Author

yanghaichao12 commented Aug 21, 2019

@thaJeztah @yongtang Thank you！

This was referenced Aug 28, 2019
Merged
Merged
@thaJeztah thaJeztah added this to the 20.03.0 milestone Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

+1 more reviewer

@yongtang yongtang yongtang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/images Image Distribution impact/changelog process/cherry-picked status/2-code-review

Projects

None yet

Milestone

20.10.0

Development

Successfully merging this pull request may close these issues.

"docker rmi -f" is stuck

5 participants

@yanghaichao12 @GordonTheTurtle @thaJeztah @yongtang @kolyshkin