docker-py: fix linting, generate junit.xml, save bundles, and various improvements#39716
Merged
thaJeztah merged 6 commits intomoby:masterfrom Aug 19, 2019
Merged
Conversation
Member
Author
|
I opened a PR in the upstream docker-py respository to update the version of |
Member
Author
|
Removing the |
114a71d to
553e4de
Compare
36cb872 to
fdfbfbb
Compare
Member
Author
|
Whoop; it works
|
6d44cb4 to
eca931c
Compare
8 tasks
tiborvass
reviewed
Aug 13, 2019
hack/make/test-docker-py
Outdated
Member
Author
There was a problem hiding this comment.
tiborvass
reviewed
Aug 13, 2019
hack/make/test-docker-py
Outdated
Member
Author
There was a problem hiding this comment.
Looks like that still works;
INFO: Starting docker-py tests...
============================= test session starts ==============================
platform linux -- Python 3.6.9, pytest-4.1.0, py-1.8.0, pluggy-0.12.0
rootdir: /src, inifile: pytest.ini
plugins: cov-2.6.1, timeout-1.3.3
collected 385 items / 5 deselected
tests/integration/api_build_test.py ....^Cmake: *** [test-docker-py] Error 130
tiborvass
approved these changes
Aug 14, 2019
- SC2006: use $(...) notation instead of legacy backticked `...` - SC2086: double quote to prevent globbing and word splitting Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This also makes sure that we can test all functionality of the daemon, because some features are not available on static binaries. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
eca931c to
8b6da9d
Compare
Member
Author
|
Rebased, and removed the |
Member
Author
|
All green; merging this one |
This was referenced Aug 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses parts of #39675
built on top of #39714 to get CI greenThis also makes sure that we can test all functionality of the daemon, because some features are not available on static binaries.