Jenkinsfile: remove "experimental" stage#39709
Merged
tiborvass merged 3 commits intomoby:masterfrom Aug 9, 2019
Merged
Conversation
Member
Author
|
@andrewhsu @tiborvass PTAL |
These tests are fixed upstream, but those fixes are not yet in a released version. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
Ah! docker-py now also runs the experimental tests, and some of those are broken in the version we use (fixes are in docker/docker-py#2382) Pushing a commit to skip them |
4461160 to
c3dcd12
Compare
AkihiroSuda
approved these changes
Aug 9, 2019
tiborvass
reviewed
Aug 9, 2019
thaJeztah
commented
Aug 9, 2019
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
All tests that require experimental either spin up a separate daemon, or use the main daemon if experimental is enabled. This patch - allows enabling "experimental" for stages through an environment variable - enables experimental by default on all stages, so that some of these tests don't have to start a new daemon. - removes the seaprate "experimental" stage, because it was running exactly the same tests as the "janky" stage. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
c3dcd12 to
e856b46
Compare
tiborvass
approved these changes
Aug 9, 2019
thaJeztah
commented
Aug 10, 2019
| --deselect=tests/integration/api_exec_test.py::ExecTest::test_detach_with_arg \ | ||
| --deselect=tests/integration/api_exec_test.py::ExecDemuxTest::test_exec_command_tty_stream_no_demux \ | ||
| --deselect=tests/integration/api_build_test.py::BuildTest::test_build_invalid_platform \ | ||
| --deselect=tests/integration/api_image_test.py::PullImageTest::test_build_invalid_platform \ |
Member
Author
There was a problem hiding this comment.
Made a copy / paste whoopsie here (see #39682 (comment), 254bb84#r312682108, #39685 (comment))
Fixing in #39714
This was referenced Aug 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #39555
All tests that require experimental either spin up a separate daemon,
or use the main daemon if experimental is enabled.
This patch
don't have to start a new daemon.
the same tests as the "janky" stage.