Fix regression in handling of NotFound err during startup ENGCORE-929#39703
Merged
thaJeztah merged 1 commit intomoby:masterfrom Aug 9, 2019
Merged
Fix regression in handling of NotFound err during startup ENGCORE-929#39703thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
Signed-off-by: Deep Debroy <ddebroy@docker.com>
thaJeztah
requested changes
Aug 8, 2019
Member
thaJeztah
left a comment
There was a problem hiding this comment.
change looks good but linting is failing;
23:55:13 Congratulations! All commits are properly signed with the DCO!
23:56:27 daemon/daemon.go:1::warning: file is not gofmted with -s (gofmt)
23:56:27 daemon/daemon.go:1::warning: file is not goimported (goimports)
daemon/daemon.go
Outdated
Member
There was a problem hiding this comment.
Suggested change
| if err != nil && !errdefs.IsNotFound(err) { | |
| if err != nil && !errdefs.IsNotFound(err) { |
This was referenced Aug 9, 2019
This was referenced Aug 9, 2019
Member
|
backport: docker-archive#317 |
StefanScherer
approved these changes
Aug 9, 2019
Contributor
StefanScherer
left a comment
There was a problem hiding this comment.
LGTM
retested with the NAV container example on Windows 10 with Docker Desktop.
Member
|
all green 💚 - merging |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Address a regression during daemon startup introduced in #38931.
fixes #39623
fixes #39742
fixes docker/for-win#4463
fixes microsoft/navcontainerhelper#548
- How I did it
Added (back) proper handling of NotFound err
- How to verify it
Start a container in Windows like:
and Restart-Computer.
After reboot, make sure container comes back up properly and is not a zombie.
- Description for the changelog
Fix regression in reboot of Windows daemon
- A picture of a cute animal (not mandatory but encouraged)