make.ps1: Run-IntegrationTests(): set working directory for test suite#39698
Merged
kolyshkin merged 1 commit intomoby:masterfrom Aug 8, 2019
Merged
make.ps1: Run-IntegrationTests(): set working directory for test suite#39698kolyshkin merged 1 commit intomoby:masterfrom
kolyshkin merged 1 commit intomoby:masterfrom
Conversation
This function changed to the correct working directory before starting the tests (which is the same as on Linux), however the `ProcessStartInfo` process does not inherit this working directory, which caused Windows tests to be running with a different working directory as Linux (causing files used in tests to not be found). From the documentation; https://docs.microsoft.com/en-us/dotnet/api/system.diagnostics.processstartinfo.workingdirectory?view=netframework-4.8 > When `UseShellExecute` is `true`, the fully qualified name of the directory that contains > the process to be started. When the `UseShellExecute` property is `false`, the working > directory for the process to be started. The default is an empty string (`""`). This patch sets the `ProcessStartInfo.WorkingDirectory` to the correct working directory before starting the process. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
Member
Author
|
Experimental failing on https://jenkins.dockerproject.org/job/Docker-PRs-experimental/46406/console PowerPC failing on https://jenkins.dockerproject.org/job/Docker-PRs-powerpc/15305/console |
Member
Author
|
And Janky on the new Jenkins is failing on https://ci.docker.com/public/job/moby/job/PR-39698/1/display/redirect |
Member
Author
|
I'm not gonna restart those; this PR only affects Windows |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function changed to the correct working directory before starting the tests
(which is the same as on Linux), however the
ProcessStartInfoprocess doesnot inherit this working directory, which caused Windows tests to be running
with a different working directory as Linux (causing files used in tests to not
be found).
From the documentation; https://docs.microsoft.com/en-us/dotnet/api/system.diagnostics.processstartinfo.workingdirectory?view=netframework-4.8
This patch sets the
ProcessStartInfo.WorkingDirectoryto the correct workingdirectory before starting the process.