Skip to content

builder-next: ensure timestamps set for metadata commands#39683

Merged
thaJeztah merged 1 commit intomoby:masterfrom
tonistiigi:builder-metadata-timestamps
Aug 7, 2019
Merged

builder-next: ensure timestamps set for metadata commands#39683
thaJeztah merged 1 commit intomoby:masterfrom
tonistiigi:builder-metadata-timestamps

Conversation

@tonistiigi
Copy link
Copy Markdown
Member

fixes #39456

from moby/buildkit#778

Signed-off-by: Tonis Tiigi tonistiigi@gmail.com

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

should we backport this?

@thaJeztah
Copy link
Copy Markdown
Member

Failure on z https://ci.docker.com/public/blue/organizations/jenkins/moby/detail/PR-39683/1/pipeline


[2019-08-07T01:34:54.313Z] FAIL: docker_cli_run_unix_test.go:210: DockerSuite.TestRunAttachDetachFromInvalidFlag
[2019-08-07T01:34:54.313Z] 
[2019-08-07T01:34:54.313Z] docker_cli_run_unix_test.go:235:
[2019-08-07T01:34:54.313Z]     c.Fatal(err)
[2019-08-07T01:34:54.313Z] ... Error: read |0: file already closed

@thaJeztah
Copy link
Copy Markdown
Member

all green now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

builder-next: metadata commands do not have created time in history

4 participants