Jenkinsfile cleanup and improvements#39656
Conversation
|
Booo! Looks like this version either doesn't support |
|
Label option was added in workflow-durable-task-step 2.28 (https://issues.jenkins-ci.org/browse/JENKINS-55410 / jenkinsci/workflow-durable-task-step-plugin#93), so perhaps the plugin installed is too old? |
|
cc @zelahi for review |
Jenkinsfile
Outdated
There was a problem hiding this comment.
If you're wanting to label these shell steps you could just stages within stages
Jenkinsfile
Outdated
There was a problem hiding this comment.
We ran into an issue where it was set locally but then the tests would consistently fail on s390x-ubuntu-1604. Was it still failing?
There was a problem hiding this comment.
Hm.. didn't know that was the case; would be interesting to know why (we can still override it for s390x/power)
There was a problem hiding this comment.
Yeah, not sure why docker build with buildkit is bonking out on 18.06...docker-ce 18.06.3 was the last s390x package version we released because the hardware maintenance has been difficult and almost no users. Perhaps we should start disabling the tests for s390x because we don't intend to ship docker-ce packages for s390x in the future.
There was a problem hiding this comment.
i see you set environment { DOCKER_BUILDKIT = '0' } in s390x and ppc64le steps. i think that's fine for now.
Jenkinsfile
Outdated
There was a problem hiding this comment.
Should this be in a cleanup block in the Jenkinsfile? https://jenkins.io/doc/book/pipeline/syntax/#post
There was a problem hiding this comment.
Rewriting the PR now to use substages; good suggestion, I'll use a cleanup block for this
4d7d374 to
709e45b
Compare
From the code style guidelines; https://wiki.jenkins.io/display/JENKINS/Code+Style+Guidelines > 1. Use spaces. Tabs are banned. > 2. Java blocks are 4 spaces. JavaScript blocks as for Java. XML nesting is 2 spaces Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The main Dockerfile is multi-arch now. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Container and image names are already unique because they have the git-sha or build-number, and a single machine won't be running tests for multiple architectures. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
709e45b to
b04c769
Compare
|
Looks indeed like both Power and Z are failing with BuildKit; Perhaps the Docker version on those machines is old? |
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
@thaJeztah I believe those went out of support before Last version released for |
|
|
||
| ''' | ||
|
|
||
| sh ''' |
There was a problem hiding this comment.
@thaJeztah not important to change, but was wondering why this was added
tiborvass
left a comment
There was a problem hiding this comment.
Thank you @thaJeztah !! This is great!
|
Looks like it's not really possible to restart individual (parallel) stages, which is a bit of a pain. Still reading up on what's possible, but linking some issues that are related;
Also looks like the declarative pipelines currently don't support "nested" parallel stages;
|
See individual commits for what changed