Cast Dev and Rdev of Stat_t to uint64 for mips#39646
Merged
thaJeztah merged 1 commit intomoby:masterfrom Aug 5, 2019
Merged
Conversation
|
Please sign your commits following these rules: $ git clone -b "master" git@github.com:ydcool/moby.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
AkihiroSuda
reviewed
Aug 1, 2019
Member
AkihiroSuda
left a comment
There was a problem hiding this comment.
LGTM, but please sign the commit with your real name including surname
Signed-off-by: Dominic <yindongchao@inspur.com> Signed-off-by: Dominic Yin <yindongchao@inspur.com>
Contributor
Author
|
@AkihiroSuda thank you, is it all right now? |
AkihiroSuda
approved these changes
Aug 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dominic Yin yindongchao@inspur.com
- What I did
This is yet another pull request based on #37490 , since that PR seems no more progresses.
This PR fixed build errors about like "cannot use s.Rdev (type uint32) as type uint64" when targeting mips due to the Dev and Rdev in Stat_t being 32-bit on 32-bit mips.
- How I did it
Inserted casts to uint64 where needed.
- How to verify it
Note that we cannot build docker on mips64le in conventional way, instead we have to run the script directly. After fix some other problems like ztypes and zerrors in golang.org/x/sys, we build docker successfully following these short steps below:
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)