Skip to content

bump libnetwork to 09cdcc8c0eab3946c2d70e8f6225b05baf1e90d1#39633

Merged
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:bump_libnetwork
Jul 31, 2019
Merged

bump libnetwork to 09cdcc8c0eab3946c2d70e8f6225b05baf1e90d1#39633
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:bump_libnetwork

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Jul 30, 2019 •
edited
Loading

full diff: moby/libnetwork@83d30db...09cdcc8

changes included:

@thaJeztah
bump libnetwork to 09cdcc8c0eab3946c2d70e8f6225b05baf1e90d1
6f234db 
full diff: moby/libnetwork@83d30db...09cdcc8

changes included:

- moby/libnetwork#2416 Fix hardcoded AF_INET for IPv6 address handling
- moby/libnetwork#2411 Macvlan network handles netlabel.Internal wrong
  - fixes moby/libnetwork#2410 Macvlan network handles netlabel.Internal wrong
- moby/libnetwork#2414 Allow network with --config-from to be --internal
  - fixes moby/libnetwork#2413 Network with --config-from does not honor --internal
- moby/libnetwork#2351 Use fewer modprobes
  - relates to moby#38930 Use fewer modprobes
- moby/libnetwork#2415 Support dockerd and system restarts for ipvlan and macvlan networks
  - carry of moby/libnetwork#2295 phantom ip/mac vlan network after a powercycle
  - fixes moby/libnetwork#1743 Phantom docker network

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah requested a review from tianon as a code owner July 30, 2019 17:40
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Jul 30, 2019

ping @arkodg @selansen @kolyshkin ptal

arkodg
arkodg approved these changes Jul 30, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Jul 30, 2019

Windows RS1 is a flaky test https://jenkins.dockerproject.org/job/Docker-PRs-WoW-RS1/26104/console

tracked through #38521

18:50:53 FAIL: docker_cli_start_test.go:190: DockerSuite.TestStartReturnCorrectExitCode
18:50:53 
18:50:53 assertion failed: expected an error, got nil

kolyshkin
kolyshkin approved these changes Jul 30, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah mentioned this pull request Jul 31, 2019
Merged
selansen
selansen approved these changes Jul 31, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@selansen selansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Jul 31, 2019

three lgtm's; I'll go ahead and merge

@thaJeztah thaJeztah merged commit 928381b into moby:master Jul 31, 2019
@thaJeztah thaJeztah deleted the bump_libnetwork branch July 31, 2019 15:03
This was referenced Aug 22, 2019
Merged
Open
@thaJeztah thaJeztah added this to the 20.03.0 milestone Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kolyshkin kolyshkin kolyshkin approved these changes

@tianon tianon Awaiting requested review from tianon tianon is a code owner

+2 more reviewers

@arkodg arkodg arkodg approved these changes

@selansen selansen selansen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/networking Networking process/cherry-picked status/2-code-review

Projects

None yet

Milestone

20.10.0

Development

Successfully merging this pull request may close these issues.

Network with --config-from does not honor --internal Macvlan network handles netlabel.Internal wrong Phantom docker network

5 participants

@thaJeztah @kolyshkin @arkodg @selansen @GordonTheTurtle