[do not merge] Testing: debug failing build on Windows RS5#39403
Closed
thaJeztah wants to merge 5 commits intomoby:masterfrom
Closed
[do not merge] Testing: debug failing build on Windows RS5#39403thaJeztah wants to merge 5 commits intomoby:masterfrom
thaJeztah wants to merge 5 commits intomoby:masterfrom
Conversation
Member
Author
|
Interesting; it now fails when downloading Git; https://jenkins.dockerproject.org/job/Docker-PRs-WoW-RS5-Process/2810/console Wonder if it's some networking issue |
0b00f35 to
cf56bf5
Compare
Member
Author
|
Changing to use Expand-Archive C:\go.zip -DestinationPath C:\ -Force;Now produces a different error: Possibly because it tries to remove |
cf56bf5 to
d6c920d
Compare
Codecov Report
@@ Coverage Diff @@
## master #39403 +/- ##
=========================================
Coverage ? 37.32%
=========================================
Files ? 609
Lines ? 45197
Branches ? 0
=========================================
Hits ? 16869
Misses ? 26039
Partials ? 2289 |
Member
Author
|
Removed the edit: argh |
d6c920d to
c740d46
Compare
Member
Author
|
Same with Go 1.12.5; trying the same approach as Git now (temp directory, then move) edit: no luck there trying |
c740d46 to
27782da
Compare
Windows RS5 builds started to fail recently;
```
15:20:17 INFO: Extracting git...
15:20:31 INFO: Expanding go...
15:20:36 Remove-Item : Cannot find path 'C:\go\' because it does not exist.
15:20:36 At C:\Windows\system32\WindowsPowerShell\v1.0\Modules\Microsoft.PowerShell.Arch
15:20:36 ive\Microsoft.PowerShell.Archive.psm1:411 char:46
15:20:36 + ... $expandedItems | % { Remove-Item $_ -Force -Recurse }
15:20:36 + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
15:20:36 + CategoryInfo : ObjectNotFound: (C:\go\:String) [Remove-Item], I
15:20:36 temNotFoundException
15:20:36 + FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.Remov
15:20:36 eItemCommand
15:20:36
```
That error looks to be triggered by the step downloading Go;
https://github.com/moby/moby/blob/6f446d041bfd690856e63e1515d0d9514f9b684a/Dockerfile.windows#L214-L215
```
Write-Host INFO: Downloading go...; `
Download-File $('https://golang.org/dl/go'+$Env:GO_VERSION+'.windows-amd64.zip') C:\go.zip; `
```
The codepath that is causing the actual error is in;
https://github.com/PowerShell/Microsoft.PowerShell.Archive/blob/v1.0.0.0/Microsoft.PowerShell.Archive/Microsoft.PowerShell.Archive.psm1#L400-L408
And is only triggered if extracting the archive fails:
```powershell
if($isArchiveFileProcessingComplete -eq $false)
{
if($expandedItems.Count -gt 0)
{
# delete the expanded file/directory as the archive
# file was not completly expanded.
$expandedItems | % { Remove-Item $_ -Force -Recurse }
}
}
```
Trying to download the previous version of Go to check if there's something different
with the archive we're downloading.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
27782da to
62f5bd3
Compare
Member
Author
|
OK, that worked, so looks like |
Member
Author
|
Wondering if it's because a redirect isn't followed; |
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
3c4be78 to
f0092a8
Compare
Member
Author
|
Changed to use the redirect URL, but that doesn't solve the issue; |
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
Hm.. looks like there's a networking issue; I changed to use the |
Member
Author
|
So.. changing the base image worked; And it fails on the image that's preloaded on the machine; So looks like that image is broken |
Member
Author
|
Checking the what version the 1809 image is, and looks like that's more recent than the one that's preloaded ( docker manifest inspect mcr.microsoft.com/windows/servercore:1809 {
"schemaVersion": 2,
"mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
"manifests": [
{
"mediaType": "application/vnd.docker.distribution.manifest.v2+json",
"size": 945,
"digest": "sha256:1daf90c37624fb4abe9556a0d2b8852d866ec62e9696d381a4000ae56c74c362",
"platform": {
"architecture": "amd64",
"os": "windows",
"os.version": "10.0.17763.557"
}
}
]
} |
This reverts commit f0092a8. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
Reverting the URL change to confirm that it's indeed an issue with the image |
Member
Author
|
Ok; build still succeeds, so looks to be an issue with that base image? |
This was referenced Jun 26, 2019
This reverts commit 62f5bd3. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Contributor
|
It appears the issue is specific to one of the VMs: |
Member
Author
|
interesting; odd that we kept hitting those broken nodes then 😞 I'll close this for now; thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to #39402
Windows RS5 builds started to fail recently;
That error looks to be triggered by the step downloading Go;
moby/Dockerfile.windows
Lines 214 to 215 in 6f446d0
The codepath that is causing the actual error is in;
https://github.com/PowerShell/Microsoft.PowerShell.Archive/blob/v1.0.0.0/Microsoft.PowerShell.Archive/Microsoft.PowerShell.Archive.psm1#L400-L408
And is only triggered if extracting the archive fails:
Trying to download the previous version of Go to check if there's something different
with the archive we're downloading.
Signed-off-by: Sebastiaan van Stijn github@gone.nl
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)