Skip to content

build: buildkit now also uses systemd's resolv.conf#39295

Merged
thaJeztah merged 1 commit intomoby:masterfrom
tiborvass:buildkit-systemd-resolvconf
Jun 4, 2019
Merged

build: buildkit now also uses systemd's resolv.conf#39295
thaJeztah merged 1 commit intomoby:masterfrom
tiborvass:buildkit-systemd-resolvconf

Conversation

@tiborvass
Copy link
Copy Markdown
Contributor

@tiborvass tiborvass commented May 31, 2019 •
edited by thaJeztah
Loading

Signed-off-by: Tibor Vass tibor@docker.com

Fixes moby/buildkit#1004

Dependent on:

Libnetwork diff: moby/libnetwork@5ac07ab...fc5a7d9

@tiborvass tiborvass requested a review from tonistiigi as a code owner May 31, 2019 21:19
@tiborvass tiborvass force-pushed the buildkit-systemd-resolvconf branch from b9fb503 to 542024c Compare May 31, 2019 21:20
@tiborvass tiborvass mentioned this pull request May 31, 2019
Merged
@tiborvass tiborvass force-pushed the buildkit-systemd-resolvconf branch 2 times, most recently from 121dfda to 99e2cf2 Compare June 4, 2019 05:04
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 4, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@2e58093). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master   #39295   +/-   ##
=========================================
  Coverage          ?   37.03%           
=========================================
  Files             ?      611           
  Lines             ?    45439           
  Branches          ?        0           
=========================================
  Hits              ?    16827           
  Misses            ?    26335           
  Partials          ?     2277

This was referenced Jun 4, 2019
Closed
Merged
build: buildkit now also uses systemd's resolv.conf
8ff4ec9 
Signed-off-by: Tibor Vass <tibor@docker.com>
@tiborvass tiborvass force-pushed the buildkit-systemd-resolvconf branch from 99e2cf2 to 8ff4ec9 Compare June 4, 2019 16:05
@tiborvass tiborvass changed the title [WIP] build: buildkit now also uses systemd's resolv.conf build: buildkit now also uses systemd's resolv.conf Jun 4, 2019
thaJeztah
thaJeztah approved these changes Jun 4, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah mentioned this pull request Jun 4, 2019
Merged
2 tasks
@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Jun 4, 2019

All green; RS1 is a known failure

@thaJeztah thaJeztah merged commit a6e1502 into moby:master Jun 4, 2019
This was referenced Jun 7, 2019
Closed
Merged
Merged
@tiborvass tiborvass deleted the buildkit-systemd-resolvconf branch July 17, 2019 00:34
@thaJeztah thaJeztah added this to the 20.03.0 milestone Apr 2, 2020
@Frederik-Baetens
Copy link
Copy Markdown

Frederik-Baetens commented Apr 22, 2020

Will this be backported to moby 19.03? I see it was backported to docker 19.03.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees

No one assigned

Labels

area/builder Build area/networking Networking area/systemd status/4-merge

Projects

None yet

Milestone

20.10.0

Development

Successfully merging this pull request may close these issues.

Buildkit does not configure DNS correctly inside container Error response from daemon: configuration network 8-2 is in use

5 participants

@tiborvass @thaJeztah @Frederik-Baetens @tonistiigi @GordonTheTurtle