Skip to content

[WIP] Bump docker-py to 4.0.1+#39239

Closed
thaJeztah wants to merge 2 commits intomoby:masterfrom
thaJeztah:bump_docker_py
Closed

[WIP] Bump docker-py to 4.0.1+#39239
thaJeztah wants to merge 2 commits intomoby:masterfrom
thaJeztah:bump_docker_py

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented May 20, 2019

update the docker-py tests to use the latest release https://github.com/docker/docker-py/releases/tag/4.0.1

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented May 20, 2019

ping @shin- @ulyssessouza PTAL

This was referenced May 20, 2019
Merged
Merged
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented May 21, 2019

Getting some errors; @shin- @ulyssessouza ptal if those need fixing;

16:52:29 ==================================== ERRORS ====================================
16:52:29 _____ ERROR at setup of AttachContainerTest.test_attach_stream_and_cancel ______
16:52:29 Error evaluating 'xfail' expression
16:52:29     
16:52:29      ^
16:52:29 SyntaxError: invalid syntax
16:52:29 ________________ ERROR at setup of TestStore.test_store_and_get ________________
16:52:29 /docker-py/tests/integration/credentials/store_test.py:31: in setup_method
16:52:29     raise Exception('No supported docker-credential store in PATH')
16:52:29 E   Exception: No supported docker-credential store in PATH
16:52:29 _______________ ERROR at setup of TestStore.test_get_nonexistent _______________
16:52:29 /docker-py/tests/integration/credentials/store_test.py:31: in setup_method
16:52:29     raise Exception('No supported docker-credential store in PATH')
16:52:29 E   Exception: No supported docker-credential store in PATH
16:52:29 _______________ ERROR at setup of TestStore.test_store_and_erase _______________
16:52:29 /docker-py/tests/integration/credentials/store_test.py:31: in setup_method
16:52:29     raise Exception('No supported docker-credential store in PATH')
16:52:29 E   Exception: No supported docker-credential store in PATH
16:52:29 _______________ ERROR at setup of TestStore.test_unicode_strings _______________
16:52:29 /docker-py/tests/integration/credentials/store_test.py:31: in setup_method
16:52:29     raise Exception('No supported docker-credential store in PATH')
16:52:29 E   Exception: No supported docker-credential store in PATH
16:52:29 ____________________ ERROR at setup of TestStore.test_list _____________________
16:52:29 /docker-py/tests/integration/credentials/store_test.py:31: in setup_method
16:52:29     raise Exception('No supported docker-credential store in PATH')
16:52:29 E   Exception: No supported docker-credential store in PATH
16:52:29 __________ ERROR at setup of TestStore.test_execute_with_env_override __________
16:52:29 /docker-py/tests/integration/credentials/store_test.py:31: in setup_method
16:52:29     raise Exception('No supported docker-credential store in PATH')
16:52:29 E   Exception: No supported docker-credential store in PATH
16:52:29 =================================== FAILURES ===================================
16:52:29 ___________________ SwarmTest.test_init_swarm_data_path_addr ___________________
16:52:29 /docker-py/tests/integration/api_swarm_test.py:254: in test_init_swarm_data_path_addr
16:52:29     assert self.init_swarm(data_path_addr='eth0')
16:52:29 /docker-py/tests/integration/base.py:127: in init_swarm
16:52:29     return self._init_swarm(self.client, **kwargs)
16:52:29 /docker-py/tests/integration/base.py:94: in _init_swarm
16:52:29     '127.0.0.1', listen_addr=helpers.swarm_listen_addr(), **kwargs
16:52:29 /docker-py/docker/utils/decorators.py:34: in wrapper
16:52:29     return f(self, *args, **kwargs)
16:52:29 /docker-py/docker/api/swarm.py:170: in init_swarm
16:52:29     return self._result(response, json=True)
16:52:29 /docker-py/docker/api/client.py:267: in _result
16:52:29     self._raise_for_status(response)
16:52:29 /docker-py/docker/api/client.py:263: in _raise_for_status
16:52:29     raise create_api_error_from_http_exception(e)
16:52:29 /docker-py/docker/errors.py:31: in create_api_error_from_http_exception
16:52:29     raise cls(e, response=response, explanation=explanation)
16:52:29 E   APIError: 400 Client Error: Bad Request ("interface eth0 has more than one IPv6 address (2001:db8:1::242:ac11:2 and fe80::42:acff:fe11:2)")
16:52:29 _________________ SwarmTest.test_join_on_already_joined_swarm __________________
16:52:29 /docker-py/tests/integration/models_swarm_test.py:37: in test_join_on_already_joined_swarm
16:52:29     client.swarm.init()
16:52:29 /docker-py/docker/models/swarm.py:126: in init
16:52:29     node_id = self.client.api.init_swarm(**init_kwargs)
16:52:29 /docker-py/docker/utils/decorators.py:34: in wrapper
16:52:29     return f(self, *args, **kwargs)
16:52:29 /docker-py/docker/api/swarm.py:170: in init_swarm
16:52:29     return self._result(response, json=True)
16:52:29 /docker-py/docker/api/client.py:267: in _result
16:52:29     self._raise_for_status(response)
16:52:29 /docker-py/docker/api/client.py:263: in _raise_for_status
16:52:29     raise create_api_error_from_http_exception(e)
16:52:29 /docker-py/docker/errors.py:31: in create_api_error_from_http_exception
16:52:29     raise cls(e, response=response, explanation=explanation)
16:52:29 E   APIError: 400 Client Error: Bad Request ("could not choose an IP address to advertise since this system has multiple addresses on different interfaces (172.17.0.2 on eth0 and 172.20.0.1 on br-eoa2i7561b7k)")
16:52:29 - generated xml file: /go/src/github.com/docker/docker/bundles/test-docker-py/results.xml -

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented May 23, 2019

@ulyssessouza I tried re-running CI, but same failures again

@shin-
Copy link
Copy Markdown
Contributor

shin- commented May 27, 2019 •
edited
Loading

@thaJeztah In v4, we baked in support for credential stores (it used to be a separate library), and so the integration tests moved as well, but they require some setup. It probably makes sense to add an env switch so that the moby test suite can skip these. I'll update here once I've done that (or if one of you gets to it before I do, feel free!)

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented May 27, 2019

We might be able to get around that if the test dockerfile does that setup and we go for #39068

@thaJeztah
Bump docker-py to 4.0.1
744ba8c 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah changed the title Bump docker-py to 4.0.1 [WIP] Bump docker-py to 4.0.1+ Jun 7, 2019
@thaJeztah
WIP bump to 0f368939def31bfd44218f54a5eff0a599ab8139
f9de708 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 7, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@c85fe2d). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #39239   +/-   ##
=========================================
  Coverage          ?   37.07%           
=========================================
  Files             ?      612           
  Lines             ?    45643           
  Branches          ?        0           
=========================================
  Hits              ?    16921           
  Misses            ?    26431           
  Partials          ?     2291

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Jun 7, 2019

added a "WIP" commit to bump to master

@thaJeztah thaJeztah mentioned this pull request Jun 26, 2019
Closed
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Jul 18, 2019

obsoleted by #39068

@thaJeztah thaJeztah deleted the bump_docker_py branch July 18, 2019 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@MHBauer MHBauer

Labels

area/testing status/2-code-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@thaJeztah @shin- @tiborvass @GordonTheTurtle @MHBauer