Remove a network during task SHUTDOWN instead of REMOVE#39174
Merged
thaJeztah merged 1 commit intomoby:masterfrom May 9, 2019
Merged
Remove a network during task SHUTDOWN instead of REMOVE#39174thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
Contributor
|
Thanks @arkodg . LGTM. Can you pls add a simple integration test to cover this scenario ? |
mavenugo
approved these changes
May 6, 2019
make sure the LB sandbox is removed when a service is updated with a --network-rm option Signed-off-by: Arko Dasgupta <arko.dasgupta@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #39174 +/- ##
=========================================
Coverage ? 37%
=========================================
Files ? 612
Lines ? 45428
Branches ? 0
=========================================
Hits ? 16809
Misses ? 26332
Partials ? 2287 |
Contributor
|
@arkodg thanks for adding the test. LGTM. |
Contributor
|
SGTM |
This was referenced May 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure the LB sandbox is removed when a service is updated
with a --network-rm option
Signed-off-by: Arko Dasgupta arko.dasgupta@docker.com
- What I did
Ensured that the LoadBalancer Sandbox is deleted when a service is updated with --network-rm option
- How I did it
Removed the removeNetworks logic from task REMOVE to task SHUTDOWN
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)