builder entitlements configuration added.#39144
Conversation
Codecov Report
@@ Coverage Diff @@
## master #39144 +/- ##
=========================================
Coverage ? 37.01%
=========================================
Files ? 612
Lines ? 45400
Branches ? 0
=========================================
Hits ? 16806
Misses ? 26307
Partials ? 2287 |
8c7aab6 to
cba50de
Compare
|
Is it still possible to get this into 19.03? |
builder/builder-next/controller.go
Outdated
There was a problem hiding this comment.
nit: conf.Entitlements.NetworkHost != nil && not needed here
There was a problem hiding this comment.
Removing conf.Entitlements.NetworkHost != nil && .. will make only way to enable Network-host is by no entry in config file.
{
"features": {
"buildkit": true
},
"builder":{
"entitlements":{
"network-host":true,
"security-insecure":false
}
}
}The above config file will also not enable network-host. I think that will be wrong behaviour.
There was a problem hiding this comment.
Sorry, I only meant the conf.Entitlements.NetworkHost != nil && part not *conf.Entitlements.NetworkHost == true after it that is still needed. Just as small cleanup because you already check if it is nil before with no functional change.
|
ping @kunalkushwaha |
|
Sorry somehow, I missed this. I will update it. |
cba50de to
1dc8318
Compare
thaJeztah
left a comment
There was a problem hiding this comment.
looks like there's two minor linting issues, causing CI to fail; could you address those? Thanks!
c705743 to
e180ea5
Compare
builder/builder-next/controller.go
Outdated
e180ea5 to
4a21d0e
Compare
buildkit supports entitlements like network-host and security-insecure. this patch aims to make it configurable through daemon.json file. by default network-host is enabled & secuirty-insecure is disabled. Signed-off-by: Kunal Kushwaha <kunal.kushwaha@gmail.com>
4a21d0e to
8b7bbf1
Compare
buildkit supports entitlements like network-host and security-insecure.
this patch aims to make it configurable through daemon.json file.
by default network-host is enabled & secuirty-insecure is disabled.
Signed-off-by: Kunal Kushwaha kunal.kushwaha@gmail.com
- What I did
option to enable/disable buildkit's entitlements settings for moby
fixes part of issue discussed here moby/buildkit#950 (comment)
- How I did it
Added
entitlementsin builder config- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)