rootless: optional support for lxc-user-nic SUID binary#39112
Merged
thaJeztah merged 1 commit intomoby:masterfrom Apr 25, 2019
Merged
rootless: optional support for lxc-user-nic SUID binary#39112thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #39112 +/- ##
==========================================
- Coverage 37.05% 37.05% -0.01%
==========================================
Files 612 612
Lines 45400 45400
==========================================
- Hits 16824 16822 -2
- Misses 26294 26297 +3
+ Partials 2282 2281 -1 |
Member
Author
tonistiigi
approved these changes
Apr 23, 2019
Member
Author
|
@tiborvass @cpuguy83 @thaJeztah PTAL? |
thaJeztah
approved these changes
Apr 25, 2019
Member
thaJeztah
left a comment
There was a problem hiding this comment.
SGTM, but left a suggestion
lxc-user-nic can eliminate slirp overhead but needs /etc/lxc/lxc-usernet to be configured for the current user. To use lxc-user-nic, $DOCKERD_ROOTLESS_ROOTLESSKIT_NET=lxc-user-nic also needs to be set. This commit also bumps up RootlessKit from v0.3.0 to v0.4.0: rootless-containers/rootlesskit@70e0502...e92d5e7 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
65bc2c7 to
63a66b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Akihiro Suda akihiro.suda.cz@hco.ntt.co.jp
- What I did
Added support for
lxc-user-nic.lxc-user-niccan eliminate slirp overhead but needs/etc/lxc/lxc-usernetto be configured for the current user.To use lxc-user-nic,
$DOCKERD_ROOTLESS_ROOTLESSKIT_NET=lxc-user-nicalso needs to be set.- How I did it
By updating RootlessKit from v0.3.0 to v0.4.0:
rootless-containers/rootlesskit@70e0502...e92d5e7
- How to verify it
$ DOCKERD_ROOTLESS_ROOTLESSKIT_NET=lxc-user-nic contrib/dockerd-rootless.sh --experimental- Description for the changelog
rootless: optional support for lxc-user-nic SUID binary
- A picture of a cute animal (not mandatory but encouraged)
🐧