bump google.golang.org/grpc v1.20.1#39062
Merged
tiborvass merged 1 commit intomoby:masterfrom May 14, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #39062 +/- ##
=========================================
Coverage ? 37%
=========================================
Files ? 612
Lines ? 45488
Branches ? 0
=========================================
Hits ? 16833
Misses ? 26358
Partials ? 2297 |
Member
|
Seems to break something on BuildKit: moby/buildkit#936 |
Member
Author
|
😞 dang; any idea what's causing it? |
|
Since moby/buildkit#936 mentions race conditions, it might be relevant that gprc-go 1.20.1 has been released after the last comment here with a fix for race conditions (not sure if applicable though): |
Member
|
tried 1.20.1, still failing |
1ef3a23 to
1a803b5
Compare
Member
Author
|
updated to v1.20.1 anyway (thanks for the ping) |
Member
|
BuildKit failure was analyzed: https://github.com/moby/buildkit/pull/936/files#r283134768 Could you bump up BuildKit as well after moby/buildkit#936 gets merged? |
full diff: grpc/grpc-go@v1.12.2...v1.20.1 includes grpc/grpc-go#2695 transport: do not close channel that can lead to panic addresses moby#39053 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
1a803b5 to
28ad54d
Compare
tonistiigi
approved these changes
May 14, 2019
tiborvass
approved these changes
May 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
full diff: grpc/grpc-go@v1.12.2...v1.20.1
includes grpc/grpc-go#2695 transport: do not close channel that can lead to panic
relates to #39053 (need to update docker/cli with this version)
depends on moby/buildkit#936