Add client.WithAPIVersionNegotiation() option#39032
Merged
thaJeztah merged 1 commit intomoby:masterfrom Apr 20, 2019
Merged
Conversation
thaJeztah
commented
Apr 8, 2019
50c984c to
bdaa4e4
Compare
Codecov Report
@@ Coverage Diff @@
## master #39032 +/- ##
=========================================
Coverage ? 37.29%
=========================================
Files ? 612
Lines ? 45801
Branches ? 0
=========================================
Hits ? 17083
Misses ? 26379
Partials ? 2339 |
bdaa4e4 to
440f674
Compare
This comment has been minimized.
This comment has been minimized.
f08819d to
b97b283
Compare
WithAPIVersionNegotiation enables automatic API version negotiation for the client. With this option enabled, the client automatically negotiates the API version to use when making requests. API version negotiation is performed on the first request; subsequent requests will not re-negotiate. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
b97b283 to
b26aa97
Compare
Member
Author
|
rebased. ping @vdemeester @tiborvass PTAL |
Member
Author
|
Only failure is a flaky test on Janky; |
Member
Author
|
ping @cpuguy83 @AkihiroSuda ptal? |
AkihiroSuda
approved these changes
Apr 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WithAPIVersionNegotiationenables automatic API version negotiation for the client.With this option enabled, the client automatically negotiates the API version to use when making requests. API version negotiation is performed on the first request; subsequent requests will not re-negotiate.