Add support for using Configs as CredentialSpecs in services#38672
Closed
thaJeztah wants to merge 1 commit intomoby:masterfrom
Closed
Add support for using Configs as CredentialSpecs in services#38672thaJeztah wants to merge 1 commit intomoby:masterfrom
thaJeztah wants to merge 1 commit intomoby:masterfrom
Conversation
Member
Author
|
ping @dperny @anshulpundir @wk8 PTAL; I think this is roughly what's needed to make it work 😅 |
8f93e53 to
325c992
Compare
thaJeztah
commented
Feb 1, 2019
7b29ff5 to
129d411
Compare
Codecov Report
@@ Coverage Diff @@
## master #38672 +/- ##
=========================================
Coverage ? 36.72%
=========================================
Files ? 610
Lines ? 45265
Branches ? 0
=========================================
Hits ? 16622
Misses ? 26359
Partials ? 2284 |
Member
Author
|
All green; |
129d411 to
e4474ce
Compare
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
e4474ce to
9cc532c
Compare
This was referenced Feb 2, 2019
Contributor
|
i added this commit to #38632, so all of the changes are in the same place. |
| // API version 1.40 | ||
| service.TaskTemplate.ContainerSpec.Sysctls = nil | ||
|
|
||
| if service.TaskTemplate.ContainerSpec.Privileges != nil && service.TaskTemplate.ContainerSpec.Privileges.CredentialSpec != nil { |
There was a problem hiding this comment.
nit: extract and factorize it with createService, as the logic is not that simple?
Member
|
Should this be closed in favor of #38632? |
Member
Author
|
Yes, let's close this one, as my changes were included in the other PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #38520
Brings in API changes for moby/swarmkit#2771
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)